Fix datalad special remote error reporting#7333
Conversation
| f"{ce.format_with_cause()}" | ||
| self.message(debug_msg) | ||
| error_causes.append(cause) | ||
| error_causes.append(ce.tb.__cause__) |
There was a problem hiding this comment.
I don't see complaints from codecov which means that this code block is probably tests covered -- could you add checking for expected cause to appear somewhere where expected in the test?
There was a problem hiding this comment.
I don't see where this is covered. test_datalad.py doesn't appear to test retrieval at all.
Utilize `CapturedException`'s `format_with_cause` instead of a custom solution, potentially leading to an error message containing an uninformative `[None]`. Closes datalad#7332
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## maint #7333 +/- ##
==========================================
+ Coverage 88.71% 90.70% +1.98%
==========================================
Files 327 327
Lines 44518 44530 +12
Branches 5908 5909 +1
==========================================
+ Hits 39494 40390 +896
+ Misses 5009 4125 -884
Partials 15 15
... and 14 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
PR released in |
Utilize
CapturedException.format_with_causeinstead of a custom solution, potentially leading to an error message containing an uninformative[None].This would also include more than just the first-level
__cause__(all the way down and include potential__context__as well)Closes #7332
With this change the output reported in #7332 (
Failed to download from any of 2 locations [None]) changes to:So, much more telling.