Extend type-annotations for datalad/support/path.py#7336
Merged
Conversation
jwodder
added
semver-internal
github-actions
Bot
removed
the
CHANGELOG-missing
yarikoptic
reviewed
Mar 16, 2023
| # if no exception raised it was not the reason, raise original | ||
| raise | ||
| except: | ||
| except Exception: |
Member
There was a problem hiding this comment.
ha -- so even logic I added in 0.10.3~18^2 (53cfc2d) was wrong since I was re-raising and then right away going into except for it... odd. This fixes that now I think. BUT I would keep it
Suggested change
| except Exception: | |
| except: |
or at least
Suggested change
| except Exception: | |
| except BaseException: |
if possible to retain original effect from getcwd crashing one way or another.
Contributor
Author
There was a problem hiding this comment.
Bare except:/except BaseException: will also catch KeyboardInterrupt and other things that normally shouldn't be caught.
yarikoptic
approved these changes
Mar 20, 2023
Collaborator
|
PR released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #6884.