Type-annotate various things in datalad/runner/
#7337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwodder
added
semver-internal
jwodder
changed the title
datalad/runner/
github-actions
bot
removed
the
CHANGELOG-missing
christian-monch
approved these changes
Mar 21, 2023
There was a problem hiding this comment.
Nice work. Thanks a lot at @jwodder.
I have got only a few comments.
|
|
||
| def close(self): | ||
| pass | ||
| fake_file = MagicMock(**{"fileno.return_value": -1, "close.return_value": None}) |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## maint #7337 +/- ##
==========================================
+ Coverage 88.69% 90.66% +1.96%
==========================================
Files 327 327
Lines 44527 44581 +54
Branches 5910 5907 -3
==========================================
+ Hits 39495 40418 +923
+ Misses 5017 4148 -869
Partials 15 15
... and 23 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Was approved and looks good to me -- let's proceed. Thank you @jwodder ! |
|
PR released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #6884.