Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type-annotate some more files in datalad/support/ #7339

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Mar 17, 2023

Part of #6884.

@jwodder jwodder added semver-internal Changes only affect the internal API CHANGELOG-missing When a PR's description does not contain a changelog item, yet. labels Mar 17, 2023
@github-actions github-actions bot removed the CHANGELOG-missing When a PR's description does not contain a changelog item, yet. label Mar 17, 2023
@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage: 97.22% and project coverage change: +2.25 🎉

Comparison is base (d506f92) 88.43% compared to head (0189bb4) 90.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##            maint    #7339      +/-   ##
==========================================
+ Coverage   88.43%   90.68%   +2.25%     
==========================================
  Files         327      327              
  Lines       44548    44557       +9     
  Branches     5911     5911              
==========================================
+ Hits        39394    40408    +1014     
+ Misses       5135     4134    -1001     
+ Partials       19       15       -4     
Impacted Files Coverage Δ
datalad/support/cookies.py 88.73% <94.44%> (+0.49%) ⬆️
datalad/support/annex_utils.py 100.00% <100.00%> (ø)
datalad/support/ansi_colors.py 100.00% <100.00%> (ø)
datalad/support/digests.py 100.00% <100.00%> (ø)

... and 29 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic yarikoptic merged commit f392b4b into datalad:maint Mar 20, 2023
@yarikoptic-gitmate
Copy link
Collaborator

PR released in 0.18.3

@jwodder jwodder deleted the type-support4 branch May 12, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants