Skip with_sameas_remote when rsync and annex are incompatible #7342
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## maint #7342 +/- ##
===========================================
- Coverage 88.13% 35.49% -52.65%
===========================================
Files 327 327
Lines 44556 44549 -7
===========================================
- Hits 39270 15811 -23459
- Misses 5286 28738 +23452 see 261 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
bpoldrack
force-pushed
the
dbg-7320
branch
3 times, most recently
from
df6736f to
2beb6d6
Compare
A fix in rsync 3.2.4 broke compatibility with older annex versions. To make things a bit more complicated, ubuntu pulled that fix into their rsync package for 3.1.3-8. Adjust the test wrapper's existing skip conditions in accordingly and reenable the test. Closes datalad#7320
bpoldrack
changed the title
bpoldrack
added
semver-tests
github-actions
bot
removed
the
CHANGELOG-missing
| # If we have a debian package version, use this as rsync version. | ||
| # Otherwise report what `rsync --version` itself has to say. | ||
| if ver: | ||
| return ver |
There was a problem hiding this comment.
IMHO this (above) is overkill since we are just talking about either we should skip the test while testing against some older git-annex .
And since this functionality is already in external_versions, then why not to assign to be reported for cmd:annex and thus avoid manual LooseVersion'ing here, and then just external_versions['cmd:rsync'] >=3.1.3 in the test? Eventually that skip would be gone anyways whenever we boost minimal git-annex version beyond that one.
or am I still missing the point warranting above complexity?
|
ok, if anything improvement can follow as a PR, let's proceed for now as is. |
|
thank you @bpoldrack ! |
|
PR released in |
A fix in rsync 3.2.4 broke compatibility with older annex versions.
To make things a bit more complicated, ubuntu pulled that fix into
their rsync package for 3.1.3-8.
Adjust the test wrapper's existing skip conditions in accordingly and
reenable the test.
Closes #7320