Fix testing assumption - do create pure GitRepo superdataset and test against it #7353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise there is no point of having two tests - one for GitRepo and one for AnnexRepo
…aset.create otherwise it becomes an AnnexRepo and thus behaving pretty much the same way as in AnnexRepo test and actually test running the same duration. With this change we get 11.45s call datalad/support/tests/test_repo_save.py::test_annexrepo_save_all 8.14s call datalad/support/tests/test_repo_save.py::test_gitrepo_save_all thus attesting to the fact that we get different testing for GitRepo case
yarikoptic
added
the
semver-tests
|
appveyor was a rare now flaky I will add changelog and merge. I don't see codecov results - but I would expect it to increase if anything |
yarikoptic
added
the
CHANGELOG-missing
github-actions
bot
removed
the
CHANGELOG-missing
|
PR released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While preparing unittest to demonstrate #7351 problem I found that the good old "parametric" test copied long time from revolution was actually not parametrized at all and thus pretty much causing running the same testing (with AnnexRepo) twice. This PR in this shape just fixes that and must not result in new failures.
As a result we do get differential timing for those two tests:
from original idential
;)