Fix failing testing on CI: Use sample S3 url DANDI archive, our copy of old .deb, specific miniconda installer for py 3.7 #7379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ObjectVersions ref: OpenNeuroOrg/openneuro#2809 I have better "control" over what happens on DANDI bucket, and this URL we share with other projects for testing ROS3 driver, so used in other projects tests
yarikoptic
changed the title
yarikoptic
added
the
CHANGELOG-missing
github-actions
bot
removed
the
CHANGELOG-missing
Although snapshots might be more "official" and thus more "reliably present" than our own server, snapshots. has all kinds of throttling settings which delay download or even cause it to fail: datalad/datalad-installer#154 although datalad-installer should retry now (after it gets upgraded within appveyor setup see datalad#7380) if size changes, I think it would still be more robust to just get it from our server. I also made a note in datalad/datalad-installer#160 so may be we gain possibility to specify multiple URLs thus to robustify. === Do not change lines below === { "chain": [], "cmd": "sed -i -e s,http://snapshot.debian.org/archive/debian/20210906T204127Z/pool/main/g/git-annex/,https://datasets.datalad.org/datalad/packages/neurodebian/,g .appveyor.yml", "exit": 0, "extra_inputs": [], "inputs": [], "outputs": [ ".appveyor.yml" ], "pwd": "." } ^^^ Do not change lines above ^^^
Python 3.7 was dropped already from recent miniconda installer scripts. So we should use most recent datalad-installer with some v0.12.0 we should be able to install desired version of miniconda and thus point to prior version which still uses python 3.7
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## maint #7379 +/- ##
==========================================
+ Coverage 88.34% 90.69% +2.35%
==========================================
Files 327 327
Lines 44685 44685
Branches 0 5922 +5922
==========================================
+ Hits 39476 40527 +1051
+ Misses 5209 4143 -1066
- Partials 0 15 +15
☔ View full report in Codecov by Sentry. |
|
Travis and appveyor are green now -- I will proceed so we let other PRs to get green. |
|
PR released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I decided to absorb all fixes to get our CI green again
I have better "control" over what happens on DANDI bucket, and this URL we share with other projects for testing ROS3 driver, so used in other projects tests
This test started to fail Apr 28th, taints other tests failures, so should be merged asap