Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add workaround for theme issues (search not working) #7385

Merged
merged 2 commits into from
May 16, 2023

Conversation

mslw
Copy link
Contributor

@mslw mslw commented May 12, 2023

This is a recommended workaround for search function & flyout menu not working on Read the Docs with a combination of sphinx-6.2.1 & sphinx-rtd-theme-1.2.0. It is likely to be fixed with sphinx-rtd-theme v1.3, at which point the change can be reverted (or we can try to wait it out).

There is no additional dependency to install, since the theme already installs sphinxcontrib.jquery.

Fixes #7374

This is a recommended workaround for search function & flyout menu not
working with a combination of sphinx-6.2.1 & sphinx-rtd-theme-1.2.0.

There is no additional dependency to install, since the theme already
installs it.

It is likely to be fixed with sphinx-rtd-theme v1.3, at which point
the commit can be reverted.

See: readthedocs/sphinx_rtd_theme#1452
@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -55.20 ⚠️

Comparison is base (c7d31e1) 88.72% compared to head (1900190) 33.53%.

❗ Current head 1900190 differs from pull request most recent head 3ff576c. Consider uploading reports for the commit 3ff576c to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##            maint    #7385       +/-   ##
===========================================
- Coverage   88.72%   33.53%   -55.20%     
===========================================
  Files         327      327               
  Lines       44686    44157      -529     
  Branches     5922     5922               
===========================================
- Hits        39647    14807    -24840     
- Misses       5024    29162    +24138     
- Partials       15      188      +173     

see 276 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mslw mslw added the semver-documentation Changes only affect the documentation, no impact on version label May 12, 2023
@mslw mslw marked this pull request as ready for review May 12, 2023 09:36
@yarikoptic yarikoptic merged commit 37efbac into datalad:maint May 16, 2023
@yarikoptic-gitmate
Copy link
Collaborator

PR released in 0.18.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-documentation Changes only affect the documentation, no impact on version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Searching function in Developer Docs hangs
3 participants