Discontinue ConfigManager abuse for Git identity warning #7392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DataLad warns about an undefined Git identity (user.name|email). It does that whether or not any Git identity is actually necessary or even anyhow considered. The `ConfigManager` constructor is (ab)used to trigger this warning, and a `ConfigManager` class member is used to prevent repeated warnings. This changeset maintains the exact same behavior (warn on `datalad import`), but move the associated code out of the `ConfigManager` class. This class is not involved in any Git repository manipulations. The warning is trigger in `datalad/__init__.py` directly, hence no protection against repeated execution is needed (Python does it automatically).
yarikoptic
added
the
CHANGELOG-missing
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## maint #7392 +/- ##
==========================================
+ Coverage 88.34% 90.68% +2.33%
==========================================
Files 327 327
Lines 44685 44692 +7
Branches 0 5923 +5923
==========================================
+ Hits 39476 40527 +1051
+ Misses 5209 4150 -1059
- Partials 0 15 +15
☔ View full report in Codecov by Sentry. |
github-actions
bot
removed
the
CHANGELOG-missing
yarikoptic
commented
Jun 3, 2023
|
PR released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reincarnated (since was not complete and prematurely merged by me) #7378 by @mih .