Skip to content

BF: Run an actual git invocation with interactive commit config #7398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 7, 2023

Conversation

adswa
Copy link
Member

@adswa adswa commented Jun 2, 2023

Fixes #7397

@adswa adswa added semver-patch Increment the patch version when merged CHANGELOG-missing When a PR's description does not contain a changelog item, yet. labels Jun 2, 2023
@github-actions github-actions bot removed the CHANGELOG-missing When a PR's description does not contain a changelog item, yet. label Jun 2, 2023
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
@codeclimate
Copy link

codeclimate bot commented Jun 6, 2023

Code Climate has analyzed commit b528574 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.25 🎉

Comparison is base (01e9831) 91.34% compared to head (b528574) 91.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7398      +/-   ##
==========================================
+ Coverage   91.34%   91.59%   +0.25%     
==========================================
  Files         325      325              
  Lines       43300    43318      +18     
  Branches     5775     5781       +6     
==========================================
+ Hits        39551    39676     +125     
+ Misses       3731     3627     -104     
+ Partials       18       15       -3     
Impacted Files Coverage Δ
datalad/support/gitrepo.py 92.03% <ø> (+0.74%) ⬆️

... and 22 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adswa
Copy link
Member Author

adswa commented Jun 6, 2023

The next failure is unrelated

@adswa
Copy link
Member Author

adswa commented Jun 7, 2023

I'm taking @yarikoptic's thumbs-up as an approval. I've tested locally that I get an interactive commit message entry when setting the config variable on the latest state of this PR.

@adswa adswa merged commit 44bf1fd into datalad:master Jun 7, 2023
@adswa adswa deleted the interactive-message-config branch June 7, 2023 09:45
@yarikoptic-gitmate
Copy link
Collaborator

PR released in 0.19.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants