Honor the copy parameter _get_adjusted_env() #7399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit lets WitlessRunner._get_adjusted_env() honor the copy parameter. It also improves the docstring of the method.
christian-monch
added
the
semver-performance
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## maint #7399 +/- ##
==========================================
+ Coverage 88.76% 91.51% +2.74%
==========================================
Files 327 325 -2
Lines 44693 43408 -1285
Branches 5924 5825 -99
==========================================
+ Hits 39671 39724 +53
+ Misses 5007 3668 -1339
- Partials 15 16 +1
☔ View full report in Codecov by Sentry. |
yarikoptic
reviewed
Jun 3, 2023
yarikoptic
reviewed
Jun 3, 2023
yarikoptic
requested changes
Jun 9, 2023
Co-authored-by: Yaroslav Halchenko <debian@onerussian.com>
This commit adds a unit test for Runner._get_adjusted_env to ensure the correct copy-behavior, i.e. copy an env only if `copy` is `True`.
|
Hi @yarikoptic , thanks for the review. Yes, a test is a good ideat. I added it. Thanks for the hint. |
This commit ensures locally, i.e. independent of previous control flow, that containment is tested against dictionaries and not against None-values. The type checker does not determine that a non-None original environment will lead to a non-None adjusted environment, when Runner._get_adjusted_env is called. We help it with an `assert` that states this fact.
|
PR released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
WitlessRunner._get_adjusted_env()to honor thecopy-parameter and perform a copy only ifcopyisTrue.In addition, it improves the docstring of the method.