BF: handle uninstalled subdatasets more gracefully - #7430
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## maint #7430 +/- ##
==========================================
- Coverage 91.48% 91.24% -0.24%
==========================================
Files 325 325
Lines 43399 43408 +9
Branches 5818 0 -5818
==========================================
- Hits 39703 39609 -94
- Misses 3681 3799 +118
+ Partials 15 0 -15
☔ View full report in Codecov by Sentry. |
Member
Author
|
Note to self: add a test, rebase on maint |
Member
|
|
Code Climate has analyzed commit 8726175 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
adswa
commented
Jul 12, 2023
Member
|
Looks good. Let's proceed! |
Collaborator
|
PR released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, an uninstalled subdataset would catch create-sibling-gitlab
off-guard, as if no path was given, its error handling would try to
iterate over a none-type object.
This change accounts for this possibility, and makes create-sibling-gitlab
handle this situation a bit more graceful and with better messaging.
Fixes #7429"