Skip to content

BF: handle uninstalled subdatasets more gracefully #7430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 1, 2023

Conversation

adswa
Copy link
Member

@adswa adswa commented Jun 16, 2023

Previously, an uninstalled subdataset would catch create-sibling-gitlab
off-guard, as if no path was given, its error handling would try to
iterate over a none-type object.
This change accounts for this possibility, and makes create-sibling-gitlab
handle this situation a bit more graceful and with better messaging.
Fixes #7429"

@adswa adswa added semver-patch Increment the patch version when merged CHANGELOG-missing When a PR's description does not contain a changelog item, yet. labels Jun 16, 2023
@github-actions github-actions bot removed the CHANGELOG-missing When a PR's description does not contain a changelog item, yet. label Jun 16, 2023
@adswa adswa linked an issue Jun 16, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.24 ⚠️

Comparison is base (5bae877) 91.48% compared to head (7b076b3) 91.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##            maint    #7430      +/-   ##
==========================================
- Coverage   91.48%   91.24%   -0.24%     
==========================================
  Files         325      325              
  Lines       43399    43408       +9     
  Branches     5818        0    -5818     
==========================================
- Hits        39703    39609      -94     
- Misses       3681     3799     +118     
+ Partials       15        0      -15     
Impacted Files Coverage Δ
...ad/distributed/tests/test_create_sibling_gitlab.py 97.29% <66.66%> (-1.30%) ⬇️
datalad/distributed/create_sibling_gitlab.py 69.46% <100.00%> (+0.55%) ⬆️

... and 39 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adswa
Copy link
Member Author

adswa commented Jul 11, 2023

Note to self: add a test, rebase on maint

@yarikoptic
Copy link
Member

yarikoptic commented Jul 11, 2023

  • I think it could go against maint.
  • Having a test would have been nice.
  • Changelog should be adjusted to note that this is create-sibling-gitlab specific, not some general handling.

@adswa adswa changed the base branch from master to maint July 12, 2023 14:16
@codeclimate
Copy link

codeclimate bot commented Jul 12, 2023

Code Climate has analyzed commit 8726175 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@yarikoptic
Copy link
Member

Looks good. Let's proceed!

@yarikoptic yarikoptic merged commit 4579b3f into datalad:maint Aug 1, 2023
@yarikoptic-gitmate
Copy link
Collaborator

PR released in 0.19.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create-sibling-gitlab --recursive stumbles on uninstalled subds
3 participants