-
Notifications
You must be signed in to change notification settings - Fork 110
BF: handle uninstalled subdatasets more gracefully #7430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## maint #7430 +/- ##
==========================================
- Coverage 91.48% 91.24% -0.24%
==========================================
Files 325 325
Lines 43399 43408 +9
Branches 5818 0 -5818
==========================================
- Hits 39703 39609 -94
- Misses 3681 3799 +118
+ Partials 15 0 -15
☔ View full report in Codecov by Sentry. |
Note to self: add a test, rebase on maint |
|
Code Climate has analyzed commit 8726175 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Looks good. Let's proceed! |
PR released in |
Previously, an uninstalled subdataset would catch create-sibling-gitlab
off-guard, as if no path was given, its error handling would try to
iterate over a none-type object.
This change accounts for this possibility, and makes create-sibling-gitlab
handle this situation a bit more graceful and with better messaging.
Fixes #7429"