Skip to content

Eliminate uses of pkg_resources #7439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Eliminate uses of pkg_resources #7439

merged 2 commits into from
Aug 1, 2023

Conversation

jwodder
Copy link
Member

@jwodder jwodder commented Jun 26, 2023

Closes #7435.

@jwodder jwodder added semver-internal Changes only affect the internal API CHANGELOG-missing When a PR's description does not contain a changelog item, yet. labels Jun 26, 2023
@github-actions github-actions bot removed the CHANGELOG-missing When a PR's description does not contain a changelog item, yet. label Jun 26, 2023
@yarikoptic
Copy link
Member

Thank you! windows on appveyor isn't happy though:


=========================== short test summary info ===========================
FAILED ..\datalad\core\local\tests\test_create.py::test_bad_cfg_proc - NameError: name 'as_file' is not defined
FAILED ..\datalad\core\local\tests\test_create.py::test_create_withcfg - NameError: name 'as_file' is not defined
=========== 2 failed, 232 passed, 24 skipped in 1685.19s (0:28:05) ============
Command exited with code 1

@jwodder
Copy link
Member Author

jwodder commented Jun 26, 2023

@yarikoptic Should be fixed now.

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -0.01 ⚠️

Comparison is base (684c842) 91.51% compared to head (c888fae) 91.50%.

Additional details and impacted files
@@            Coverage Diff             @@
##            maint    #7439      +/-   ##
==========================================
- Coverage   91.51%   91.50%   -0.01%     
==========================================
  Files         325      325              
  Lines       43392    43402      +10     
  Branches     5819     5822       +3     
==========================================
+ Hits        39711    39717       +6     
- Misses       3666     3670       +4     
  Partials       15       15              
Impacted Files Coverage Δ
datalad/cli/parser.py 85.33% <54.54%> (-1.16%) ⬇️
datalad/support/external_versions.py 95.58% <87.50%> (-0.51%) ⬇️
datalad/local/run_procedure.py 96.31% <100.00%> (+0.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@yarikoptic
Copy link
Member

It was green back then, debian has the dependency even in oldstable so let's proceed

@yarikoptic yarikoptic merged commit 1e56aaa into datalad:maint Aug 1, 2023
@yarikoptic-gitmate
Copy link
Collaborator

PR released in 0.19.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-internal Changes only affect the internal API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace uses of pkg_resources
3 participants