-
Notifications
You must be signed in to change notification settings - Fork 109
Pass branch option into recursive call within Install - for the cases whenever install is invoked with URL(s) #7463
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
datalad/distribution/install.py
Outdated
@@ -200,7 +200,6 @@ def __call__( | |||
reckless=None, | |||
jobs="auto", | |||
branch=None): | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unrelated change, I will drop
Happens whenever install is invoked with a URL and --branch option. Closes datalad#7461. TODO: - [ ] test that case, so far tests had explicit "source" specified and thus did not trigger this code path
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## maint #7463 +/- ##
==========================================
+ Coverage 90.73% 91.34% +0.60%
==========================================
Files 325 325
Lines 43399 43407 +8
Branches 0 5818 +5818
==========================================
+ Hits 39380 39650 +270
+ Misses 4019 3742 -277
- Partials 0 15 +15
☔ View full report in Codecov by Sentry. |
eh, travis is unhappy but seems unrelated e.g.
so I will take it out of draft. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a fix to me 💯
PR released in |
Happens whenever install is invoked with a URL and --branch option. Closes #7461.
TODO: