Pass branch option into recursive call within Install - for the cases whenever install is invoked with URL(s)#7463
Merged
Conversation
yarikoptic
commented
Jul 28, 2023
| reckless=None, | ||
| jobs="auto", | ||
| branch=None): | ||
|
|
Member
Author
There was a problem hiding this comment.
unrelated change, I will drop
Happens whenever install is invoked with a URL and --branch option. Closes datalad#7461. TODO: - [ ] test that case, so far tests had explicit "source" specified and thus did not trigger this code path
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## maint #7463 +/- ##
==========================================
+ Coverage 90.73% 91.34% +0.60%
==========================================
Files 325 325
Lines 43399 43407 +8
Branches 0 5818 +5818
==========================================
+ Hits 39380 39650 +270
+ Misses 4019 3742 -277
- Partials 0 15 +15
☔ View full report in Codecov by Sentry. |
Member
Author
|
eh, travis is unhappy but seems unrelated e.g. so I will take it out of draft. |
Collaborator
|
PR released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Happens whenever install is invoked with a URL and --branch option. Closes #7461.
TODO: