Skip to content

Disable some S3 tests of their VCR taping where they fail for known issues#7467

Merged
yarikoptic merged 2 commits into
datalad:maintfrom
yarikoptic:bf-tests-s3
Aug 7, 2023
Merged

Disable some S3 tests of their VCR taping where they fail for known issues#7467
yarikoptic merged 2 commits into
datalad:maintfrom
yarikoptic:bf-tests-s3

Conversation

@yarikoptic

Copy link
Copy Markdown
Member

No description provided.

@yarikoptic yarikoptic added semver-tests Changes only affect tests, no impact on version CHANGELOG-missing When a PR's description does not contain a changelog item, yet. labels Aug 2, 2023
@github-actions github-actions Bot removed the CHANGELOG-missing When a PR's description does not contain a changelog item, yet. label Aug 2, 2023
@codecov

codecov Bot commented Aug 2, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.07% ⚠️

Comparison is base (5b69f70) 90.74% compared to head (98f176d) 90.68%.
Report is 12 commits behind head on maint.

Additional details and impacted files
@@            Coverage Diff             @@
##            maint    #7467      +/-   ##
==========================================
- Coverage   90.74%   90.68%   -0.07%     
==========================================
  Files         325      325              
  Lines       43407    43420      +13     
==========================================
- Hits        39390    39375      -15     
- Misses       4017     4045      +28     
Files Changed Coverage Δ
datalad/downloaders/tests/test_s3.py 48.63% <100.00%> (-2.73%) ⬇️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mslw mslw mentioned this pull request Aug 2, 2023
@yarikoptic

Copy link
Copy Markdown
Member Author

sample failing tests on travis are unrelated:

=========================== short test summary info ============================
FAILED ../datalad/customremotes/tests/test_archives.py::test_basic_scenario - datalad.runner.exception.CommandError: CommandError: 'git -c diff.ignoreSubmodules=none -c core.quotepath=false annex get -c annex.retry=3 --json --json-error-messages --json-progress -c annex.dotfiles=true -- ' |;&%b5{}'"'"'"<>ΔЙקم๗あ .dbtc '' failed with exitcode 1 under /tmp/datalad_temp_tree_test_basic_scenario6k4ahijq [info keys: stdout_json]
> from datalad-archives...
from datalad-archives...
from datalad-archives...
Unable to access these remotes: datalad-archives
  Failed to fetch any archive containing MD5E-s3--202cb962ac59075b964b07152d234b70. Tried: ['MD5E-s142--170b63d398cfbb66a3b561073c6a566f.tar.gz']
  Failed to fetch any archive containing MD5E-s3--202cb962ac59075b964b07152d234b70. Tried: ['MD5E-s142--170b63d398cfbb66a3b561073c6a566f.tar.gz', 'MD5E-s142--170b63d398cfbb66a3b561073c6a566f.tar.gz']
  Failed to fetch any archive containing MD5E-s3--202cb962ac59075b964b07152d234b70. Tried: ['MD5E-s142--170b63d398cfbb66a3b561073c6a566f.tar.gz', 'MD5E-s142--170b63d398cfbb66a3b561073c6a566f.tar.gz'] [err: 'git-annex: get: 1 failed']
FAILED ../datalad/customremotes/tests/test_archives.py::test_annex_get_from_subdir - datalad.runner.exception.CommandError: CommandError: 'git annex drop -- ' |;&%b5{}'"'"'"<>ΔЙקم๗あ .datc '' failed with exitcode 1
FAILED ../datalad/tests/test_archives.py::test_decompress_file[None] - assert False
FAILED ../datalad/tests/test_archives.py::test_decompress_file[strip] - assert False
FAILED ../datalad/tests/test_archives.py::test_ExtractedArchive - AssertionError: /tmp/datalad_temp_d0b4e3b649_szuv9hkc/ |;&%b5{}'"<>ΔЙקم๗あ .dbtc / |;&%b5{}'"<>ΔЙקم๗あ .datc  must exist

@yarikoptic yarikoptic merged commit 637ccda into datalad:maint Aug 7, 2023
@yarikoptic-gitmate

Copy link
Copy Markdown
Collaborator

PR released in 0.19.3

@yarikoptic yarikoptic deleted the bf-tests-s3 branch February 2, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver-tests Changes only affect tests, no impact on version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants