Skip to content

Allow for reckless=ephemeral clone using relative path for the original location #7472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 10, 2023

Conversation

yarikoptic
Copy link
Member

The last commit is actual fix + test, and prior one is just RFing test to avoid duplication and then reuse common testing logic in the fix. That fix fixes #7469

@yarikoptic yarikoptic added cmd-clone semver-patch Increment the patch version when merged CHANGELOG-missing When a PR's description does not contain a changelog item, yet. labels Aug 9, 2023
@github-actions github-actions bot removed the CHANGELOG-missing When a PR's description does not contain a changelog item, yet. label Aug 9, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.18% 🎉

Comparison is base (637ccda) 91.32% compared to head (260da00) 91.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##            maint    #7472      +/-   ##
==========================================
+ Coverage   91.32%   91.51%   +0.18%     
==========================================
  Files         325      325              
  Lines       43424    43425       +1     
  Branches     5822     5821       -1     
==========================================
+ Hits        39658    39741      +83     
+ Misses       3751     3669      -82     
  Partials       15       15              
Files Changed Coverage Δ
datalad/core/distributed/clone_ephemeral.py 91.66% <100.00%> (+0.36%) ⬆️
datalad/core/distributed/tests/test_clone.py 98.43% <100.00%> (-0.01%) ⬇️

... and 24 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yarikoptic
Copy link
Member Author

container -- new fail unrelated , filed datalad/datalad-container#216

travis - archives tests... unrelated, need fixing. So overall -- ready for review/merge

@yarikoptic yarikoptic added merge-if-ok OP considers this work done, and requests review/merge release Create a release when this pr is merged labels Aug 9, 2023
@yarikoptic
Copy link
Member Author

ok, I have fixed travis (see #7474) - it was due to neurodebian recent changes... we are all green. Reviews are welcome but since it is fixing an issue, I would proceed with the merge and cutting a release tomorrow if no objections are voiced.

@yarikoptic yarikoptic merged commit f3c58f3 into datalad:maint Aug 10, 2023
@yarikoptic-gitmate
Copy link
Collaborator

PR released in 0.19.3

@yarikoptic yarikoptic deleted the bf-reckless-relative branch November 27, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmd-clone merge-if-ok OP considers this work done, and requests review/merge release Create a release when this pr is merged semver-patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clone --reckless=ephemeral jumps into .. folder for original repo
2 participants