New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync from Github is replacing "Banner image link" with user's Github profile photo #121

Open
philshem opened this Issue Aug 26, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@philshem
Copy link

philshem commented Aug 26, 2018

When I sync from the linked Github repo's Readme.md, the project page replaces any existing Banner Image with the user's profile photo from Github.

I think this is not desired behavior, because the user's github profile photo has nothing to do with the project. Possible solutions would be a "banner.png" file in the Github repo, or just removing the sync for "Banner image link" if it has been manually set.

@loleg

This comment has been minimized.

Copy link
Member

loleg commented Aug 27, 2018

Thanks for raising this @philshem - but it felt like adding the GitHub profile would be better than nothing at all. And many projects start their own organisations, which have an appropriate logo.

However, the second point you mention - not overriding fields on sync - is a very much desired improvement, and is already being tracked in #83

@loleg loleg added the duplicate label Aug 27, 2018

@loleg loleg referenced this issue Oct 14, 2018

Merged

Sync aside #126

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment