Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filters / query string are lost when going through Azure Active Directory login process. #1041

Closed
oliverholliday opened this issue Oct 7, 2020 · 4 comments
Labels
Milestone

Comments

@oliverholliday
Copy link

When you're given a link containing a query to a particular set of results the authentication process loses the filters and redirects you back to the 'homepage' dashboard with no filters.

To Reproduce

  1. Use Seq configured to use Azure Active Directory login integration
  2. Log out of Seq
  3. Visit a link containing search parameters to a particular set of results
    e.g. http://seq.local/#/events?filter=Stack%20%3D%20%22test%22
  4. You are redirected via the login process
  5. Once logged in the query is lost and you are sent to the unfiltered home page
    e.g. http://seq.local/#/events

Expected behavior
The login process would preserve the filters to display the results expected for the link that was clicked.

Context
We use Seq very heavily internally and being able to link to a certain application stack / installation is very important to us. We repeatedly get confusion from users who have clicked a link and see a set of results entirely different to that seen by everybody else - because they went through the login process.

@nblumhardt
Copy link
Member

Thanks for the note; this is a longstanding issue, it's time we gave it another look 👍

@nblumhardt
Copy link
Member

Hi folks - unfortunately we're going to need to drop this from next week's 2021.2 release.

In the current 2021.2 preview release, however, we've added an experimental feature flag that we hope may offer some clues as to how to reduce the number of logouts for people using AAD with Seq.

It's enabled with:

seq config set -k features.enabled -v oidcsavetokens
seq service restart

or by setting the SEQ_FEATURES_ENABLED environment variable to oidcsavetokens.

It would be great if anyone experiencing issues with AAD logouts could try this and let us know whether it helps. Thanks!

cc @janpieterz

@nblumhardt
Copy link
Member

We're moving this out of the 2021.3 milestone, there are a lot of improvements ready to ship and unfortunately we don't have time remaining to squeeze this one in.

Sorry about postponing this for a second time! We'll consider this a bump up the priority list in our next round of planning.

@nblumhardt nblumhardt removed this from the 2021.3.x milestone Oct 11, 2021
@nblumhardt nblumhardt added this to the 2021.4.x milestone Dec 2, 2021
@nblumhardt
Copy link
Member

Great news, this one is in 2021.4! Sorry it's taken so long 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants