Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fatal circle is hard to see in dark theme #769

Closed
gkinsman opened this Issue Dec 3, 2018 · 7 comments

Comments

Projects
None yet
4 participants
@gkinsman
Copy link

gkinsman commented Dec 3, 2018

Hi there!

Loving the new dark theme to bits - one slight issue though is that the fatal circle style is almost impossible to discern on the dark background 馃檪.

image

It also doesn't appear in the stream view:

image

I'm not sure what a better colour would be for fatal events in dark theme, but I'm sure you'll come up with something awesome!

Cheers,
George

@nblumhardt nblumhardt added this to the 5.1-pre milestone Dec 3, 2018

@nblumhardt

This comment has been minimized.

Copy link
Member

nblumhardt commented Dec 3, 2018

Thanks @gkinsman - we should come up with a better system for level colors in the dark theme 馃憤

@taspeotis

This comment has been minimized.

Copy link

taspeotis commented Jan 7, 2019

鈽狅笍 or 馃拃 contrast on black and have a semantic equivalence with fatal...

@nblumhardt

This comment has been minimized.

Copy link
Member

nblumhardt commented Jan 7, 2019

Thanks @taspeotis :-)

@SeriousM

This comment has been minimized.

Copy link

SeriousM commented Jan 18, 2019

There is a fatal indicator? I was worried that Seq just dropped it and migrated it with Error. The usual fatal color is something Pink-ish as I've seen it over the last couple of years in various tools.

@nblumhardt

This comment has been minimized.

Copy link
Member

nblumhardt commented Jan 21, 2019

image

:-)

@SeriousM

This comment has been minimized.

Copy link

SeriousM commented Jan 21, 2019

@gkinsman

This comment has been minimized.

Copy link
Author

gkinsman commented Jan 21, 2019

Gracias!

@nblumhardt nblumhardt closed this Jan 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.