Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payloads sizes measured differently for compact and "classic" ingestion formats #878

Closed
nblumhardt opened this issue Aug 15, 2019 · 0 comments

Comments

@nblumhardt
Copy link
Member

commented Aug 15, 2019

When event payload size for "classic" JSON events is measured, the size considered is the normalized, on-disk event size.

For compact JSON payloads, the size of the payload as sent by the client is considered.

This means that, especially when large property values are duplicated inside message templates, there's a big difference between what's allowed in either case.

To fix this, we should either change the way "classic" payloads are measured during ingestion, or switch Serilog.Sinks.Seq to use compact: true by default (effectively obsoleting the old format).

Via @CKarstenDtag at serilog/serilog-sinks-seq#123

@nblumhardt nblumhardt added the bug label Aug 15, 2019

@nblumhardt nblumhardt added this to the 5.1-patch5 milestone Aug 15, 2019

@nblumhardt nblumhardt closed this Aug 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.