Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ArgumentException while trying to date range filter #886

Closed
Suchiman opened this issue Sep 9, 2019 · 1 comment
Closed

ArgumentException while trying to date range filter #886

Suchiman opened this issue Sep 9, 2019 · 1 comment
Labels
bug
Milestone

Comments

@Suchiman
Copy link

@Suchiman Suchiman commented Sep 9, 2019

Did this query
@Timestamp > Now() - 10s
received a display worth of log, scrolled to the end to trigger seq loading more events.
Loading indicator popped up for a few seconds, then turned into an unhandled exception:

System.ArgumentException: The range `start` must be before or equal to the range `end`.
   at Flare.Time.DateTimeRangeBounds..ctor(Nullable`1 start, Nullable`1 end)
   at Flare.Events.EventStoreRange.GetOuterBounds()
   at Flare.Events.EventStore.Get(EventStoreRange range, CancellationToken cancel, RetrievalStatistics statistics)+MoveNext()
   at System.Linq.Enumerable.EnumerablePartition`1.ToArray()
   at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source)
   at Flare.Queries.DataStore.GetFilter(Int32 count, Nullable`1 startAfter, Nullable`1 startFrom, Nullable`1 rangeStartUtc, Nullable`1 rangeEndUtc, String filter, IndexExpression indexExpression, Nullable`1 shortCircuitAfter, EventRetrievalStatistics& statistics)
   at Seq.Server.Web.Api.EventsController.QueryEvents(IndexedFilter indexedFilter, EventRetrievalStatistics& stats)
   at Seq.Server.Web.Api.EventsController.InSignal(Signal signal, Boolean excludeStats)
   at lambda_method(Closure , Object , Object[] )
   at Microsoft.AspNetCore.Mvc.Internal.ActionMethodExecutor.SyncActionResultExecutor.Execute(IActionResultTypeMapper mapper, ObjectMethodExecutor executor, Object controller, Object[] arguments)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.InvokeActionMethodAsync()
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.InvokeNextActionFilterAsync()
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Rethrow(ActionExecutedContext context)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Internal.ControllerActionInvoker.InvokeInnerFilterAsync()
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeNextResourceFilter()
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Rethrow(ResourceExecutedContext context)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.Next(State& next, Scope& scope, Object& state, Boolean& isCompleted)
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeFilterPipelineAsync()
   at Microsoft.AspNetCore.Mvc.Internal.ResourceInvoker.InvokeAsync()
   at Microsoft.AspNetCore.Builder.RouterMiddleware.Invoke(HttpContext httpContext)
   at Seq.Server.Web.Middleware.WebSocketAcceptMiddleware.Invoke(HttpContext context)
   at Seq.Server.Web.Middleware.RequestAuthenticationMiddleware.Invoke(HttpContext httpContext)
   at Seq.Server.Web.Middleware.HstsMiddleware.Invoke(HttpContext context)
   at Seq.Server.Web.Middleware.BrowserSecurityOptionsMiddleware.Invoke(HttpContext context)
   at Seq.Server.Web.Middleware.RequestCompletionMiddleware.Invoke(HttpContext httpContext)

Btw. i have Automatically send internal error reports to Datalust on, does it write in the log if a report has been sent?

@nblumhardt nblumhardt added the bug label Sep 9, 2019
@nblumhardt

This comment has been minimized.

Copy link
Member

@nblumhardt nblumhardt commented Sep 9, 2019

Thanks for the report, Robin. The API should sort out the date range overlap to prevent this error being shown to the client - we do this in a few places but seems like we've missed one, here.

Thanks for turning on error reporting. Any "@l":"Error" event shown in the internal log will be forwarded as an error report (though heavily redacted); I just dug through the recent data here and spotted this one 👍

@KodrAus KodrAus added this to the 6.0-pre milestone Sep 12, 2019
@KodrAus KodrAus closed this Oct 22, 2019
@nblumhardt nblumhardt modified the milestones: 6.0-pre, 5.1-patch6 Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.