Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
UI Improvement - Retention - Make "All Events" more visible #891
maybe just a suggestion for a UI improvement, when configuring the Retention policies.
When the "Delete" drop-down list is open, it's not super clear that the first item means "All Events". I know it's also written underneath, bu maybe it would be helpful to have a name for that option in the list.
something like :
it's not very nice, but it's a bit more explicit :P
(seen on Firefox on MacOS)
Just took a look, and this looks fine
Just a doubt, maybe it has always been this way ... I see that when creating a new Retention policy, those are the defaults :
i.e. by default, delete ALL events NOW .
Looks like there might be a risk of shooting oneself in the foot here
Is there any legit scenario where a policy that deletes events after 0 days and 0 hours should be acceptable ? In that case it sounds more like a "if you want to delete events, do it this other way" suggestion would be better ?
maybe that's a completely separate issue though, and not so much of a problem ... I'll let you triage this the way you want it :P