Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Improvement - Retention - Make "All Events" more visible #891

Closed
tsimbalar opened this issue Oct 1, 2019 · 4 comments
Closed

UI Improvement - Retention - Make "All Events" more visible #891

tsimbalar opened this issue Oct 1, 2019 · 4 comments
Labels
Milestone

Comments

@tsimbalar
Copy link

@tsimbalar tsimbalar commented Oct 1, 2019

Hi,

maybe just a suggestion for a UI improvement, when configuring the Retention policies.

image

image

When the "Delete" drop-down list is open, it's not super clear that the first item means "All Events". I know it's also written underneath, bu maybe it would be helpful to have a name for that option in the list.

something like :

image

it's not very nice, but it's a bit more explicit :P

(seen on Firefox on MacOS)

@nblumhardt

This comment has been minimized.

Copy link
Member

@nblumhardt nblumhardt commented Oct 2, 2019

Thanks @tsimbalar , we'll do this 👍

@nblumhardt nblumhardt added this to the 6.0-pre milestone Oct 2, 2019
@KodrAus KodrAus closed this Oct 17, 2019
@nblumhardt

This comment has been minimized.

Copy link
Member

@nblumhardt nblumhardt commented Oct 31, 2019

The (very, very early) 6.0 preview now at https://datalust.co/download and datalust/seq:preview on Docker Hub now include this. Would be great to get your feedback on how this turned out, if you have a chance to take a look. Thanks again!

@tsimbalar

This comment has been minimized.

Copy link
Author

@tsimbalar tsimbalar commented Nov 4, 2019

Just took a look, and this looks fine 👍

image

Just a doubt, maybe it has always been this way ... I see that when creating a new Retention policy, those are the defaults :

image

i.e. by default, delete ALL events NOW .

Looks like there might be a risk of shooting oneself in the foot here 🤔

Is there any legit scenario where a policy that deletes events after 0 days and 0 hours should be acceptable ? In that case it sounds more like a "if you want to delete events, do it this other way" suggestion would be better ?

maybe that's a completely separate issue though, and not so much of a problem ... I'll let you triage this the way you want it :P

@nblumhardt

This comment has been minimized.

Copy link
Member

@nblumhardt nblumhardt commented Nov 4, 2019

You're right - it's a bit of a risky default. A better duration picker would help, here, but we'll look at changing it to, say, 30, to avoid the worst footgun in the meantime 👍

@nblumhardt nblumhardt modified the milestones: 6.0-pre, 5.1-patch6 Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.