Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seq Nuget client not correctly following links #893

Closed
benPearce1 opened this issue Oct 16, 2019 · 7 comments
Closed

Seq Nuget client not correctly following links #893

benPearce1 opened this issue Oct 16, 2019 · 7 comments
Labels
bug
Milestone

Comments

@benPearce1
Copy link

@benPearce1 benPearce1 commented Oct 16, 2019

I am receiving a 404 response when attempting to install a Nuget package from https://f.feedz.io/octopus-deploy/dependencies/nuget/index.json.
Using the v2 Nuget feed (https://f.feedz.io/octopus-deploy/dependencies/nuget) also produces a 404 response.

The specific package that I am trying to install on my Seq installation is Seq.App.VictorOps.

Seq version 5.1.3200 gives the error: Response status code does not indicate success: 404 ().
The same package from the same feed is installing successfully on 5.1.3000.

It appears that the NuGet client within Seq is failing to follow the links in the response as it is trying to download the package from /octopus-deploy/dependencies/nuget/v3/registration-gz-semver2/seq.app.victorops/0.1.0.json
The link in the response that should be used is /octopus-deploy/dependencies/nuget/v3/registration-gz-semver2/seq.app.victorops/0.1.0/index.json.
The version.json request URL is a convention used by Nuget.org.

The above feeds are public so you can use these for testing.

@nblumhardt

This comment has been minimized.

Copy link
Member

@nblumhardt nblumhardt commented Oct 16, 2019

Thanks for the report, @benPearce1! Makes sense, we'll take a look 👍

@nblumhardt nblumhardt added the bug label Oct 16, 2019
@nblumhardt nblumhardt added this to the 6.0-pre milestone Oct 16, 2019
@KodrAus

This comment has been minimized.

Copy link
Member

@KodrAus KodrAus commented Oct 17, 2019

Hi @benPearce1 👋

It would be great to support feedz.io package feeds. Do you need to use the V2 protocol, or are you able to use V3? We do have a little more work to do in the V3 implementation to support feedz.io specifically, but it should just be a matter of following more of the hypermedia protocol.

@benPearce1

This comment has been minimized.

Copy link
Author

@benPearce1 benPearce1 commented Oct 17, 2019

Hi @KodrAus,

Not forced to use either the v2 or the v3, but they are both failing with a 404.

@nblumhardt

This comment has been minimized.

Copy link
Member

@nblumhardt nblumhardt commented Oct 25, 2019

Fixed for the v3 protocol in the upcoming 6.0-pre build. We will reevaluate v2 support in the future but haven't investigated it and would prefer to concentrate our effort on the newer protocol version. Perspectives/feedback welcome on this :-)

Thanks again for the report! An MSI/image will be available in the next couple of weeks.

@nblumhardt nblumhardt closed this Oct 25, 2019
@nblumhardt

This comment has been minimized.

Copy link
Member

@nblumhardt nblumhardt commented Oct 25, 2019

Just checked the v2 failure, it's a 404 on:

https://f.feedz.io/octopus-deploy/dependencies/FindPackagesById()?id='Seq.App.VictorOps'

Note the missing nuget element in the path. Adding a trailing / to the v2 feed base URL fixes it.

I think we can make a fairly safe change here and consider v2 feed URLs as referring to "directories" even without the trailing slash. Will reopen.

@nblumhardt nblumhardt reopened this Oct 25, 2019
@droyad

This comment has been minimized.

Copy link

@droyad droyad commented Oct 25, 2019

Awesome thanks. I just checked and MyGet also doesn't have a trailing / in the URL they advertise for v2

@KodrAus KodrAus closed this Oct 25, 2019
@KodrAus

This comment has been minimized.

Copy link
Member

@KodrAus KodrAus commented Oct 31, 2019

Hi @benPearce1 @droyad 👋

Just an update here that we've got a preview build (6.0.3342-pre) out now that should support feedz.io 🎉

@nblumhardt nblumhardt modified the milestones: 6.0-pre, 5.1-patch6 Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.