Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to async/await #52

merged 4 commits into from Sep 11, 2019


Copy link

commented Sep 9, 2019

Closes #51

This is still a really early work in progress! But I'm not expecting a lot of changes to the server module while Rust's async/await and surrounding ecosystem stabilizes so I think it'll be reasonable to keep track of things here until we're ready to bet on it.

@KodrAus KodrAus marked this pull request as ready for review Sep 11, 2019
@KodrAus KodrAus force-pushed the KodrAus:feat/async-await branch from e898495 to 7342c96 Sep 11, 2019

This comment has been minimized.

Copy link
Member Author

commented Sep 11, 2019

Alrighty this should be ready for a review now @nblumhardt

It does a few things:

  • Ports to the async/await syntax, which means using std::future::Future and upgrading to some alpha releases of tokio. We can track these as they stabilize.
  • Reworks our integration tests to be more capable and adds some more (there's still a lot of work to do here to build up a decent suite).

I think it's worth pushing ahead with this even though it shifts us onto a nightly compiler and unstable versions of tokio because it simplifies our async infrastructure a lot and appears to have shaken out some issues in the UDP side.

KodrAus added 2 commits Sep 11, 2019
+ Sync
+ Unpin
+ Clone
+ 'static,

This comment has been minimized.

Copy link
Copy link

left a comment

Just a thought, since this is such a deep set of changes, it may be worth incrementing the major version for this - to communicate the potential for behavioral changes, and so that anyone experiencing issues with either the new or old version can confidently switch between them. What do you think?

@KodrAus KodrAus merged commit 6b9682d into datalust:dev Sep 11, 2019
1 check passed
1 check passed
continuous-integration/appveyor/pr AppVeyor build succeeded
@KodrAus KodrAus deleted the KodrAus:feat/async-await branch Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.