Add target .NET Framework 4.5 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Alex, thanks for the PR! .NET Standard runs on .NET 4.5, so this is already supported. Is there an issue I'm overlooking? Regards, |
|
The main reason to make these change is to prevent importing a lot of dll's from .NET Standard. |
|
Makes sense, thank you @ar1k. |
|
A 1.0.1-dev-nnnnn build should be on NuGet shortly; if you have an opportunity to check it out and confirm everything works as expected that would be great. Thanks again! |
|
Thanks for accept the PR. I've installed a new version of package and checked it, everything works as expected. |
|
Great, thank you. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've found, that Superpower, being one of dependencies of Serilog.Filters.Expressions, builds only for .NETStandard 1.0. So, I suggest to build it for .NET 4.5 too.