Skip to content
This repository has been archived by the owner on Apr 17, 2018. It is now read-only.

Commit

Permalink
Stripped whitespace
Browse files Browse the repository at this point in the history
  • Loading branch information
dkubb authored and snusnu committed Dec 29, 2009
1 parent 9bf4a45 commit 1257694
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 9 deletions.
13 changes: 6 additions & 7 deletions CHANGELOG
Expand Up @@ -25,20 +25,20 @@
active_model/lint itself isn't really strict about what exact
String it gets back from either of the following methods that
are supported by the object returned from #class.model_name

#singular
#plural
#element
#human
#collection
#partial_path

All lint cares about, is that these methods return Strings

Therefore it's probably best to push specs that test for
rails's own implementation of those active_model strings
down to something like rails_datamapper.

Currently the rails compliance specs for #collection and
#partial_path fail. Need to investigate this.

Expand All @@ -55,7 +55,7 @@
DataMapper::Validate::ValidationErrors seems to implement
#[](field) in an incompatible way. This will need more
investigation.

If this can be fixed upstream, all specs should pass

[4b1ccd0 | Wed Sep 23 22:37:59 UTC 2009] snusnu <gamsnjaga@gmail.com>
Expand All @@ -66,12 +66,11 @@
to perform the compliance tests. However, lint.rb still
needs to be updated to cover the intended behavior more
precisely.

Nevertheless, next step is to include active_model as a
development dependency and run both lint.rb and our own
specs for the time being.

[2eb914c | Wed Sep 23 18:23:27 UTC 2009] snusnu <gamsnjaga@gmail.com>

* Initial commit to dm-active_model.

2 changes: 1 addition & 1 deletion README.rdoc
Expand Up @@ -3,7 +3,7 @@
This plugin makes datamapper compliant with active_model conventions and thus compatible with rails3.

== Note on Patches/Pull Requests

* Fork the project.
* Make your feature addition or bug fix.
* Add tests for it. This is important so I don't break it in a
Expand Down
2 changes: 1 addition & 1 deletion spec/rails_compliance_spec.rb
Expand Up @@ -47,4 +47,4 @@ class ProfileInfo
@model.class.model_name.partial_path.should == ActiveModel::Name.new(@model.class).partial_path
end

end
end

0 comments on commit 1257694

Please sign in to comment.