Permalink
Commits on Jun 19, 2009
  1. @dkubb

    Updated gemspec and history

    dkubb committed Jun 19, 2009
Commits on Jun 17, 2009
  1. @dkubb

    Remove coercion of octal, binary, hex for Integer properties

    * This extra behavior is probably unecessary and would be little used.
      In addition it would cause "0123" to be treated as 83 rather than 123,
      which I think is probably more expected to anyone familiar with how
      String#to_i works.  It's only really the Kernel::Integer() method that
      treats "0123" as an octal, and it's in far less frequent use than
      String#to_i.
    
      If specific octal, binary or hex coercion is necessary then I would
      probably suggest using a custom type rather than an Integer property.
    
      I am removing this for now, since if I'm wrong it will be easy to add
      back in, but it would be really difficult to remove behavior like this
      after a release.
    dkubb committed Jun 17, 2009
Commits on Jun 16, 2009
  1. @dkubb

    Fixed regression due to variable clobbering

    * Added spec to ensure Collection#delegate_to_relationship returns
      the expected Collection when more than one Resource is returned
      from the results.
    dkubb committed Jun 16, 2009
  2. @rsim @dbussink

    bugfix in PropetySet#<< method which affected property definition ove…

    …rrides in other repositories
    rsim committed with dbussink Jun 16, 2009
  3. @dkubb

    Refactored CRUD methods across Resource and Collections

    * Updated docs for 1:m and m:m CRUD methods
    dkubb committed Jun 16, 2009
  4. @dkubb

    Added specs for Property#valid?

    * Refactored Property#valid? once all branches were covered
    dkubb committed Jun 16, 2009
  5. @dkubb
  6. @dkubb

    Update Relationship#query_for to respect target model scope

    [#897 state:resolved]
    dkubb committed Jun 16, 2009
Commits on Jun 15, 2009
  1. @dkubb
  2. @dkubb
  3. @dkubb

    Move URI specific normalization logic into normalize_options_uri

    * Use String#<< instead of String#+ where possible since it doesn't
      create a new String instance.
    dkubb committed Jun 15, 2009
  4. @dkubb
  5. @dkubb
  6. @dkubb

    Updated DataMapper.setup to delegate to DataMapper::Adapters.setup

    * Moved logic from DataMapper.setup to DataMapper::Adapters, and
      split up the work across smaller, single purpose methods.
    dkubb committed Jun 15, 2009
  7. @dkubb
  8. @dkubb

    Unrolled comparison logic

    dkubb committed Jun 15, 2009
  9. @dkubb

    Factored out validity tests from Query::AbstractComparison

    * Created Relationship#valid? to test a Resource to see if it would be
      a valid target resource
    * Created Property#valid? to test a value to see if it matches the
      constraints for the Property
    dkubb committed Jun 15, 2009
Commits on Jun 14, 2009
  1. @dkubb

    Pass relationship/resource/collection into adapter directly

    * Pushed foreign key mapping into the adapter so that it can handle more
      of the logic itself.  This allows adapters to storage engines that do
      not link relationships using the PK/FK concept used by RDBMS'.
    * Allows for the possible use of subqueries in engines that support it,
      since if we pass in a Collection, we should be able to use it's Query
      object to construct a subquery.
    dkubb committed Jun 8, 2009
  2. @dkubb

    Compare in-memory records against expected value

    * Sometimes the @value needs to be passed through record_value
      to get the expected value.  This performs that function when the
      comparison is initialized.
    dkubb committed Jun 14, 2009
  3. @dkubb

    Removed unecessary save in spec

    dkubb committed Jun 14, 2009
  4. @dkubb
  5. @dkubb
Commits on Jun 13, 2009
  1. @dbussink
  2. @dkubb

    Bump extlib dep to 0.9.13

    dkubb committed Jun 13, 2009
  3. @dkubb

    Delegate Resource#save and #update to #save! and #update!

    * Work should be performed by "unsafe" method, while the "safe" methods
      are used by hooks.
    * Changed Resource#_update to simply be available for hooks, and
      delegates to Resource#update!
    dkubb committed Jun 13, 2009
  4. @dkubb
  5. @dkubb
  6. @dkubb

    Remove dependent Resources first

    * Minor tweak to code that loads plugins when running specs
    dkubb committed Jun 13, 2009
  7. @dkubb
  8. @dkubb
  9. @dkubb

    Added Query#valid? to short-circuit invalid queries

    * Some queries were being sent to the adapter when they would not
      return *any* results because they were invalid (like specifying that
      the value must match one entry in an empty list).
    * Added AbstractCondition#valid? and AbstractOperation#valid?
    dkubb committed Jun 13, 2009
  10. @dkubb
  11. @dkubb

    Allow ManyToMany::Relationship subclasses/mix-ins to specify options …

    …for the join relationship
    dkubb committed Jun 13, 2009
Commits on Jun 12, 2009
  1. @dkubb

    Use String#to_i for integer/float, and Integer() for octal/binary/hex

    * This represents a change in how we typecast values.  If the value
      does not match a format we know can be coerced into the object, then
      we skip typecasting and leave the value as-is.  If dm-validations is
      enabled, the value can be identified as invalid, but the original
      value is left alone by dm-core rather than turned into a nil.
    dkubb committed Jun 12, 2009