Change Direction/Operator precedence (fixes regression at d4377a9ee407b48) #150

merged 1 commit into from Oct 9, 2011


None yet

2 participants


Direction descends from Operator, yet it appears after Operator in the case..when statement here. As a result, any Direction used here is rebuilt from the concrete class, which makes it impossible to subclass (as I need to do for part of an extension).

@emmanuel emmanuel merged commit 03f14bc into datamapper:release-1.2 Oct 9, 2011
DataMapper member

Nice catch!

These case statements should (eventually) be replaced with proper polymorphism (sounds like a Visitor), but they're not going away tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment