Fix for Collection#slice incorrect offset adjustments for chained negative offsets #202

wants to merge 1 commit into


None yet

1 participant


Existing processing of offset does not account for pre-existing query conditions (such as limit and add_reversed?), thus breaking all cases of chained application of #slice where at least one offset is negative.

Tests for such cases added.

This change can be used as a base for chained #last behavior fix (also broken)

Eugene Kalenkovich Fix for Collection#slice offset adjustment behavior not accounting fo…
…r reversed query (for correct slice with negative offset chaining)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment