Do not validate Float unless precision and scale are explicitly defined

[#1038 state:resolved]

dm-validations/lib/dm-validations/validators/numeric_validator.rb

@@ -80,8 +80,8 @@ def validate_numeric(value, errors)
         precision = options[:precision]
         scale     = options[:scale]
 
-        regexp = if precision
-          if scale.nil? || precision > scale && scale == 0
+        regexp = if precision && scale
+          if precision > scale && scale == 0
             /\A[+-]?(?:\d{1,#{precision}}(?:\.0)?)\z/
           elsif precision > scale
             /\A[+-]?(?:\d{1,#{precision - scale}}|\d{0,#{precision - scale}}\.\d{1,#{scale}})\z/

dm-validations/spec/fixtures/basketball_player.rb

@@ -26,7 +26,8 @@ class BasketballPlayer
         # Validations
         #
 
-        validates_is_number :height, :weight
+        # precision and scale need to be defined for length to be validated
+        validates_is_number :height, :weight, :precision => 10
       end
       BasketballPlayer.auto_migrate!
 

dm-validations/spec/integration/numeric_validator/float_type_spec.rb

@@ -14,7 +14,6 @@
     it_should_behave_like "valid model"
   end
 
-
   describe "with height as integer" do
     before :all  do
       @model.height = 198
@@ -23,7 +22,6 @@
     it_should_behave_like "valid model"
   end
 
-
   describe "with height as string containing only integers" do
     before :all  do
       @model.height = "198"
@@ -32,7 +30,6 @@
     it_should_behave_like "valid model"
   end
 
-
   describe "with height as string containing a float" do
     before :all do
       @model.height = "198.1"
@@ -62,7 +59,6 @@
     it_should_behave_like "invalid model"
   end
 
-
   describe "with height as string containing random punctuation characters" do
     before :all do
       @height = '$$ * $?'
@@ -76,7 +72,6 @@
     it_should_behave_like "invalid model"
   end
 
-
   describe "with nil height" do
     before :all do
       @model.height = nil