Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Browse files

Bump multi_json dependency to ~> 1.3.2

  • Loading branch information...
commit fdb91e4fcddd38ae142c9e70064231ece68e2d7f 1 parent 4b85eec
@snusnu snusnu authored
View
2  dm-types.gemspec
@@ -19,7 +19,7 @@ Gem::Specification.new do |gem|
gem.add_runtime_dependency('dm-core', '~> 1.3.0.beta')
gem.add_runtime_dependency('bcrypt-ruby', '~> 3.0.0')
gem.add_runtime_dependency('fastercsv', '~> 1.5.4')
- gem.add_runtime_dependency('multi_json', '~> 1.2.0')
+ gem.add_runtime_dependency('multi_json', '~> 1.3.2')
gem.add_runtime_dependency('stringex', '~> 1.3.0')
gem.add_runtime_dependency('uuidtools', '~> 2.1.2')
View
4 lib/dm-types/json.rb
@@ -21,7 +21,7 @@ def dump(value)
if value.nil? || value.is_a?(::String)
value
else
- MultiJson.encode(value)
+ MultiJson.dump(value)
end
end
@@ -31,7 +31,7 @@ def typecast(value)
if value_loaded?(value)
value
else
- MultiJson.decode(value.to_s)
+ MultiJson.load(value.to_s)
end
end
View
2  spec/unit/json_spec.rb
@@ -19,7 +19,7 @@
describe 'when Json encoded primitive string is provided' do
it 'returns decoded value as Ruby string' do
- @property.load(MultiJson.encode(:value => 'JSON encoded string')).should == { 'value' => 'JSON encoded string' }
+ @property.load(MultiJson.dump(:value => 'JSON encoded string')).should == { 'value' => 'JSON encoded string' }
end
end

3 comments on commit fdb91e4

@d11wtq

Any chance of a 1.2.0.1 release (should be compatible with dm-core ~> 1.2.0)? We're getting held back with other gems due to this.

@d11wtq

BTW, the management of the DM gems makes it really hard to make something like this a :git reference to master in the Gemfile, since the DM versions conflict with each other if you try that. It probably makes sense not to bump version numbers until a release is actually occurring. I'm sure you guys are thinking about that, but I run into it quite often and there's not really a clean way around it, far from forking the gem purely to modify its gemspec.

@solnic
Owner

We'll be releasing 1.3.0.beta shortly. I can't push 1.2.0.1 with updated multi_json dep cause it's a breaking change.

Please sign in to comment.
Something went wrong with that request. Please try again.