Uniqueness check should only be skipped if the field is blank #61

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@pnomolos

Default behaviour for the uniqueness validator is to skip over a field if it is allowed to be blank or nil. It should only skip those fields if they are also set to blank, otherwise uniqueness errors can occur. Attached is a fix and an updated spec.

@dkubb dkubb closed this Apr 3, 2015
@pnomolos

@dkubb Wondering if there's any specific reason if this was closed? I'd be willing to fix any merge issues if you still would like the PR :)

@dkubb
DataMapper member

@pnomolos it was probably closed because the release-1.2 branch was removed. I didn't intentionally set out to close this PR.

If you want to reopen a PR against the master branch we can look at testing it and merging it in. One requirement is that the build continue to pass (or if it is failing, not for there to be a regression where more tests fail than before). We'll have all the builds passing shortly that aren't.

The main reason for the release-1.2 branch removal was simply because we wanted to get all dev being done against the master branch and not fragment development further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment