Permalink
Commits on Apr 25, 2011
  1. Bump version numbers

    dbussink committed Apr 25, 2011
Commits on Apr 18, 2011
Commits on Apr 16, 2011
  1. [do_oracle] Fix RSpec API deprecation warnings

    myabc committed Apr 16, 2011
    Signed-off-by: Alex Coles <alex@alexbcoles.com>
Commits on Apr 12, 2011
  1. [do_oracle] Fix format of test JDBC Connection URL

    myabc committed Apr 12, 2011
    Signed-off-by: Alex Coles <alex@alexbcoles.com>
  2. [do_jdbc] Minor TestCase formatting fixes, cleanup

    myabc committed Apr 12, 2011
    Signed-off-by: Alex Coles <alex@alexbcoles.com>
  3. [all multi] Uncomment out JDBC URL specs

    myabc committed Apr 12, 2011
    * Previous commit # b10e4c1 was premature.
    
    Signed-off-by: Alex Coles <alex@alexbcoles.com>
  4. [all multi] Remove note on JDBC URLs from README

    myabc committed Apr 12, 2011
    * This issue should now be (mostly) resolved.
    
    Signed-off-by: Alex Coles <alex@alexbcoles.com>
  5. [data_objects] Fix shared Connection spec / sqlite3

    myabc committed Apr 12, 2011
    * An invalid ::memory URL was being specified for specing disposal of connections.
    
    Signed-off-by: Alex Coles <alex@alexbcoles.com>
Commits on Apr 11, 2011
  1. [do_jdbc] Fix compilation against JRuby 1.5.6

    myabc committed Apr 11, 2011
    * Workaround RubyString#newString that only exists in JRuby 1.6.0.
    * The original workaround (see commit # 343bf5c) should be removable
      once JRuby 1.6.1 is out.
      (See resolved issue http://jira.codehaus.org/browse/JRUBY-5646)
    
    Signed-off-by: Alex Coles <alex@alexbcoles.com>
  2. [data_objects] Fix pending spec for non-pooling connections

    myabc committed Apr 11, 2011
    Signed-off-by: Alex Coles <alex@alexbcoles.com>
  3. [do_jdbc] Remove JNDITestSetup and JNDITestSetupTestCase

    myabc committed Apr 11, 2011
    * Now implemented in JRuby: See previous commit # 133bb3b.
    * Previous test case is better off as an integration test, run for each
      JRuby driver.
    
    Signed-off-by: Alex Coles <alex@alexbcoles.com>
  4. [do_jdbc] First step to *actual* support for JNDI, JBDC URLs

    myabc committed Apr 3, 2011
    * Despite our claims to support JNDI and JDBC URLs, this support has in
      practice been broken. Its debatable whether JDBC URLs are true URIs,
      but nevertheless we want to support them.
    
    * Modify our DataObjects::URI class a) to handle `subscheme` as a URI
      component (NOTE: we don't yet support multiple subschemes) and b) to
      distinguish between opaque and relative URIs.
    * Start making specs for DataObjects::URI and Connection more robust.
    * Rework JNDITestSetup code in JRuby.
    
    Signed-off-by: Alex Coles <alex@alexbcoles.com>
  5. [all] Update README info on running specs

    myabc committed Apr 11, 2011
    * Fix copy-paste error in data_objects README.
    
    Signed-off-by: Alex Coles <alex@alexbcoles.com>
  6. Reflect move to GH Issues

    myabc committed Apr 11, 2011
    Signed-off-by: Alex Coles <alex@alexbcoles.com>
  7. [all] Remove Jeweler dep. from Gemfile

    myabc committed Apr 10, 2011
    Signed-off-by: Alex Coles <alex@alexbcoles.com>
Commits on Apr 10, 2011
  1. Revert "[data_objects] Remove Bundler refs from Rakefile"

    myabc committed Apr 10, 2011
    This reverts commit e7afa91.
Commits on Apr 9, 2011
  1. [data_objects][ci] Fix regression from prev. commit

    myabc committed Apr 9, 2011
    * Spec task for data_objects doesn't need compilation.
    
    Signed-off-by: Alex Coles <alex@alexbcoles.com>
  2. [all][ci] Disable bundler with RSpec task

    myabc committed Apr 9, 2011
    * Clutching at straws here, but attempting to solve Gem activation error.
    
    Signed-off-by: Alex Coles <alex@alexbcoles.com>
  3. [data_objects] Remove Bundler refs from Rakefile

    myabc committed Apr 9, 2011
    * Temporary fix for CI. For some reasons 'bundle exec rake spec' causing
      a Gem activation error.
    
    Signed-off-by: Alex Coles <alex@alexbcoles.com>
Commits on Apr 7, 2011
  1. [all] Remove Jeweler, use Bundler gem tasks

    myabc committed Apr 7, 2011
    * Jeweler doesn't really add much value – in fact working around issues
      with Jeweler's "opinionated" way of doing things is more trouble than
      it's worth. A particularly "wrong" behaviour IMO is that Jeweler now
      automatically pulls Gemfile-specified dependencies into a .gemspec –
      for us, we need this to work the other way around, with the .gemspec
      being canonical and Gemfile allowing specific dependencies to be over-
      ridden for certain platforms or environments.
    
    * Use Bundler for everything: at least for the time-being.
    
    * Building different gems for multiple platforms (binary and source) may
      mean Hoe + plugins + Isolate would be a better solution, but this
      would need further investigation (I am not sure how Isolate would
      handle other, dependent gems in the same source tree).
    
    Signed-off-by: Alex Coles <alex@alexbcoles.com>
Commits on Apr 6, 2011
Commits on Apr 3, 2011
  1. [do_mysql] Properly close Reader in metadata specs

    myabc committed Apr 3, 2011
    * See previous commit # cf6b18b for workaround explanation.
    
    Signed-off-by: Alex Coles <alex@alexbcoles.com>
  2. [data_objects] Further minor cleanup

    myabc committed Apr 3, 2011
    * Workaround issue where 'its' is temporarily redefining subject,
      resulting in a NoMethodError where we want to close the subject
      (Connection) in an after block.
    
    * Thanks to dkubb for the pointers.
    
    Signed-off-by: Alex Coles <alex@alexbcoles.com>
Commits on Apr 2, 2011
  1. [data_objects] First pass refactoring specs

    myabc committed Apr 2, 2011
    * Take advantage of new syntax available in RSpec.
    
    Signed-off-by: Alex Coles <alex@alexbcoles.com>
  2. Add define for Rubinius, because we're a nicely behaving extension

    dbussink committed Apr 2, 2011
    This can greatly improve performance in Rubinius. We don't change
    a string buffer from Ruby nilly willy.
  3. Fix subsecond Time handling

    dbussink committed Apr 2, 2011
  4. Update copyright dates

    myabc committed Apr 2, 2011
    Signed-off-by: Alex Coles <alex@alexbcoles.com>
Commits on Apr 1, 2011
  1. [do_jdbc] Fix Reader#fields inconsistency w/ column aliases

    myabc committed Apr 1, 2011
    * Previously C drivers were respecting aliases, whereas Java drivers
      were not, by virtue of our use of ResultSetMetaData#getColumnName
      rather than ResultSetMetaData#getColumnLabel.
    
    * This didn't become apparent because MySQL's Connector/J 5.0.x did
      not respect the JDBC Spec and followed aliases when
      ResultSetMetaData#getColumnLabel was invoked.
    
      This only became apparanet when we upgraded our versions of MySQL
      Connector/J to 5.1.x and found that dm-migrations broke. This
      necessitated a workaround – see dm-migrations commit # bd32f73:
    
      datamapper/dm-migrations@bd32f73
    
    * This commit should obviate need for this workaround.
    
    * This commit also adds explicit specs for MySQL's database metadata
      SQL queries, to avoid future regressions.
    
    Signed-off-by: Alex Coles <alex@alexbcoles.com>
  2. Revert "[do_jdbc] Added dynamic proxy for various classes"

    myabc committed Apr 1, 2011
    * While proxing provides potential for instrumentation, for the
      time-being its not something we're using and adds another layer of
      complexity to the code-base (which if anything we should working on
      simplifying).
    
    This reverts commit 82644ec.
    
    Conflicts:
    
    	do_mysql/ext-java/src/main/java/do_mysql/MySqlDriverDefinition.java
    	do_sqlserver/ext-java/src/main/java/do_sqlserver/SqlServerDriverDefinition.java
    
    Signed-off-by: Alex Coles <alex@alexbcoles.com>