New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move query instantiation to StoreManager to avoid plugin mechanism lookups #238

Closed
andyjefferson opened this Issue Jul 6, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@andyjefferson
Member

andyjefferson commented Jul 6, 2017

Currently when we call
pm.newQuery(...)
or
em.createQuery(...)

this will go through the QueryManagerImpl which invokes the plugin mechanism to get an instance of a Query of the right type.

A better way would be to have methods on StoreManager
Query newQuery(String language, ExecutionContext ec); Query newQuery(String language, ExecutionContext ec, String singleString); Query newQuery(String language, ExecutionContext ec, Query q);

and hence avoid the lookup, since each XXXStoreManager will know what query languages it supports.

This means that the extension point "org.datanucleus.store_query_query" will not be needed.

@andyjefferson andyjefferson added this to the 5.1.0.m5 milestone Jul 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment