Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rsp cover does not handle negative coordinates #64

Closed
paumillet opened this issue Jul 9, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@paumillet
Copy link

commented Jul 9, 2019

Hello,

Thanks for sharing your work.
I've just starting playing with Robosat.pink and my area of interest is located in Nantes, France surroundings. For this area, longitudes are negative and are then not recognized as argument for parameter --bbox. I actually got the error rsp cover: error: argument --bbox: expected one argument so I guess they are detected as being the next parameter because of the sign -.

I personally fixed it with a simple trick, I now enter my bounding box with squared brackets [] and then process the input string to remove the brackets in cover.py.
But it's probably not the only place where negative longitudes could have an impact in Robosat.pink. I then let you handle this issue to have a proper update on the whole repository but I stay available if you need.

Cheers,
Pauline

@ocourtin ocourtin closed this in 6ddc417 Jul 9, 2019

@ocourtin

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2019

Hi @paumillet

Thanks for this report, i've just commited a fix on this,
thanks in advance to test it and check it...

Cheers,

@paumillet

This comment has been minimized.

Copy link
Author

commented Jul 9, 2019

Hi @ocourtin ,
I'm afraid your commit did not fix the issue, I still have the same error...

@paumillet

This comment has been minimized.

Copy link
Author

commented Jul 9, 2019

My bad, I was in the wrong virtual env, it works !

@ocourtin

This comment has been minimized.

Copy link
Collaborator

commented Jul 9, 2019

Great !
And thanks for the check Pauline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.