This repository has been archived by the owner on Mar 27, 2024. It is now read-only.
fix(responsivity): fixed page structure and responsivity #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The page is now responsive and ensure that the description will not exceed 100% of the available width
solid-bases
commented
Apr 13, 2023
Proposaldo you like a navbar such this? Desktop Mobile If you do, I'll open a dedicated PR with this change. |
|
Looks great to me! Thanks for the fixes! |
Yes please, that looks amazing |
|
Just validating in the devcontainer here |
SQLDBAWithABeard
approved these changes
Apr 13, 2023
|
Super awesome. I am really really pleased. Thank you so much. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The page is now responsive and ensure that both the cover image and the description will not exceed 100% of the available width.
Changes has been cross checked (visual comparison between localhost and datasaturdays.com) between the following pages
The header background has been changed to
bg-darkas I supposed that was the intended use ofnavbar-darkand to avoid header color changes between mobile and desktop website version.