Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to monorepo #175

Merged
merged 10 commits into from Mar 1, 2021
Merged

Convert to monorepo #175

merged 10 commits into from Mar 1, 2021

Conversation

newsroomdev
Copy link
Member

@newsroomdev newsroomdev commented Feb 16, 2021

Summary

The mighty Voltron assembles

This PR converts the repo into a yarn 2 monorepo (see docs)

Proposed changes

  • Restructures the entire repo to include a new packages/ dir with suites and the test class
  • Adds editor specific configs for running the monorepo in vim and vscode
  • Fixes sample size issues that lead to false positives
  • Upgrades packages to remove security vulnerabilities
  • Migrates docs to .github
  • Adds necessary viability checks (install, lint, and run) for windows, mac, and linux

Issues

@newsroomdev newsroomdev marked this pull request as ready for review February 16, 2021 03:11
@ejfox
Copy link
Contributor

ejfox commented Feb 22, 2021

🚀🚀🚀🔥🔥🎉🚀🔥🚀😍

@newsroomdev newsroomdev linked an issue Mar 1, 2021 that may be closed by this pull request
Copy link
Contributor

@ejfox ejfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ejfox ejfox merged commit f957d98 into dev Mar 1, 2021
@ejfox ejfox deleted the monorepo branch March 1, 2021 23:50
newsroomdev added a commit that referenced this pull request May 1, 2021
* Convert to working monorepo

* linter

* add lint step

* remove outdated update.sh

* update workflow

* fix workflow typo

* use updated yarn args

* fix npm cmd typo

* appease windows linter

* add rows info
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants