Skip to content

Conversation

@pStefanec
Copy link

@pStefanec pStefanec commented Oct 9, 2025

both dockerfiles are now pushed to docker hub, the smaller will replace dataquest/dspace-angular and the full image will go into dataquest/dspace-angular-dev

issue: https://github.com/dataquest-dev/dspace-customers/issues/343

Phases MP MM MB MR JM Total
ETA 0 0 0 0 0 0
Developing 0 0 0 0 0 0
Review 0 0 0 0 0 0
Total - - - - - 0
ETA est. 0
ETA cust. - - - - - 0

Problem description

Reported issues

Not-reported issues

Analysis

(Write here, if there is needed describe some specific problem. Erase it, when it is not needed.)

Problems

(Write here, if some unexpected problems occur during solving issues. Erase it, when it is not needed.)

…ce dataquest/dspace-angular and the full image will go into dataquest/dspace-angular-dev
@pStefanec pStefanec self-assigned this Oct 9, 2025
milanmajchrak
milanmajchrak previously approved these changes Oct 9, 2025
@milanmajchrak milanmajchrak requested a review from vidiecan October 9, 2025 13:05
@vidiecan vidiecan requested a review from Copilot October 10, 2025 07:11
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR optimizes Docker image sizes by introducing a production-ready minified image configuration and reorganizing the build pipeline to support both development and production images.

  • Adds memory optimization for Angular builds in the production Dockerfile
  • Reconfigures GitHub workflow to build both development and production Docker images
  • Updates image naming convention where the minified image replaces the main image and the full image becomes the development variant

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
Dockerfile.dist Adds NODE_OPTIONS environment variable to increase memory limit for Angular production builds
.github/workflows/docker.yml Updates workflow to build both dev and production images with proper naming and removes disabled dist build

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

@vidiecan vidiecan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copilot!

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@pStefanec pStefanec merged commit 3c05d2d into dtq-dev Oct 15, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants