From cf29c76aa3a5aa216f552ae53b3c6902c4e46876 Mon Sep 17 00:00:00 2001 From: Matus Kasak Date: Thu, 23 Oct 2025 14:32:47 +0200 Subject: [PATCH 1/4] Added check for running script after updating i18n messages --- .github/pull_request_template.md | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 76ff6196da6..a6da7c8df0c 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,11 +1,3 @@ -| Phases | MP | MM | MB | MR | JM | Total | -|-----------------|----:|----:|----:|-----:|-----:|-------:| -| ETA | 0 | 0 | 0 | 0 | 0 | 0 | -| Developing | 0 | 0 | 0 | 0 | 0 | 0 | -| Review | 0 | 0 | 0 | 0 | 0 | 0 | -| Total | - | - | - | - | - | 0 | -| ETA est. | | | | | | 0 | -| ETA cust. | - | - | - | - | - | 0 | ## Problem description ### Reported issues ### Not-reported issues @@ -13,3 +5,6 @@ (Write here, if there is needed describe some specific problem. Erase it, when it is not needed.) ## Problems (Write here, if some unexpected problems occur during solving issues. Erase it, when it is not needed.) + +If you updated en.json5 or cs.json5 file with translations: +- [ ] Verify the sync-i18n-files script was executed and any changes are included in this PR. \ No newline at end of file From d6edddc4ca2f719517a6b133affa595836fbacec Mon Sep 17 00:00:00 2001 From: Matus Kasak Date: Thu, 30 Oct 2025 11:21:46 +0100 Subject: [PATCH 2/4] Updated template and added check for manual testing --- .github/pull_request_template.md | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index a6da7c8df0c..41c9976512d 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,10 +1,13 @@ ## Problem description -### Reported issues -### Not-reported issues + ## Analysis (Write here, if there is needed describe some specific problem. Erase it, when it is not needed.) ## Problems (Write here, if some unexpected problems occur during solving issues. Erase it, when it is not needed.) -If you updated en.json5 or cs.json5 file with translations: -- [ ] Verify the sync-i18n-files script was executed and any changes are included in this PR. \ No newline at end of file +### Sync verification +If en.json5 or cs.json5 translation files were updated: +- [ ] Run `yarn run sync-i18n -t src/assets/i18n/cs.json5 -i` to synchronize messages, and changes are included in this PR. + +### Manual Testing (if applicable) +- [ ] Added to testing scenarios. From 30169e8f22254e33cd45a65e8bfd3472509eb758 Mon Sep 17 00:00:00 2001 From: Matus Kasak Date: Thu, 30 Oct 2025 13:42:36 +0100 Subject: [PATCH 3/4] Added link to test scenarios --- .github/pull_request_template.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 41c9976512d..edfc069d29a 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -10,4 +10,4 @@ If en.json5 or cs.json5 translation files were updated: - [ ] Run `yarn run sync-i18n -t src/assets/i18n/cs.json5 -i` to synchronize messages, and changes are included in this PR. ### Manual Testing (if applicable) -- [ ] Added to testing scenarios. +- [ ] Added to [testing scenarios](https://github.com/dataquest-dev/dspace-customers/issues/55) From ae7861ba93757ad697ce6a6d4b8f063df498eac4 Mon Sep 17 00:00:00 2001 From: Matus Kasak Date: Thu, 30 Oct 2025 14:51:10 +0100 Subject: [PATCH 4/4] Added check to copilot review --- .github/pull_request_template.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index edfc069d29a..8efe0f8cf86 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -11,3 +11,6 @@ If en.json5 or cs.json5 translation files were updated: ### Manual Testing (if applicable) - [ ] Added to [testing scenarios](https://github.com/dataquest-dev/dspace-customers/issues/55) + +### Copilot review +- [ ] Requested review from Copilot \ No newline at end of file