UFAL/Uncomment running unit tests #1082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by using beforeEach/afterEach for spy cleanup and correcting array index for reversed version order
|
metadata service tests were failing because of this change -> #1070 |
… calls with TestBed.runInInjectionContext()
There was a problem hiding this comment.
Pull Request Overview
This PR re-enables the CI/CD pipeline's linting, circular dependency checks, and unit tests that were previously commented out, along with the necessary test fixes to ensure they pass.
Key Changes
- Re-enabled lint, circular dependency checks, and unit test execution in GitHub Actions workflow
- Fixed test setups to use proper Angular testing patterns (
beforeEachinstead ofbeforeAllwith async, proper injection context) - Updated tests to align with CLARIN customizations that removed certain UI elements (version numbers, dates, summaries)
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/build.yml | Uncommented linting, circular dependency checks, and unit test steps in the CI pipeline |
| src/app/item-page/versions/item-versions.component.spec.ts | Fixed async test setup patterns, added proper cleanup in afterEach hooks, and updated comments about CLARIN-specific UI changes |
| src/app/core/metadata/metadata.service.spec.ts | Removed trailing space from mock translation strings to match actual implementation |
| src/app/bitstream-page/legacy-bitstream-url-redirect.guard.spec.ts | Added TestBed configuration and wrapped resolver calls in injection context to support Angular's inject() function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description
Analysis
(Write here, if there is needed describe some specific problem. Erase it, when it is not needed.)
Problems
(Write here, if some unexpected problems occur during solving issues. Erase it, when it is not needed.)
Sync verification
If en.json5 or cs.json5 translation files were updated:
yarn run sync-i18n -t src/assets/i18n/cs.json5 -ito synchronize messages, and changes are included in this PR.Manual Testing (if applicable)
Copilot review