FIX: Add quotes to curl download command #939

Matus-Beke · 2025-07-29T11:42:41Z

This pull request addresses the issue where the generated curl command for downloading files was missing quotes around the filename and the URL. This could cause issues when pasting the command into a command-line environment.

The fix was applied in the generateCurlCommand() method within the clarin-files-section.component.ts file. The string concatenation was modified to wrap both the output filename (allzip.zip) and the full URL in double quotes (").

Closes #933

Summary by CodeRabbit

Bug Fixes
- Improved formatting of the generated curl command by adding quotes around the output filename and URL to ensure better compatibility when copying and running the command.

coderabbitai · 2025-07-29T11:42:49Z

Walkthrough

The update revises the construction of a curl command string in the generateCurlCommand() method, ensuring that both the output filename and the URL are wrapped in double quotes. The change affects string formatting only, without altering the underlying logic or control flow.

Changes

Cohort / File(s)	Change Summary
Curl Command String Formatting `src/app/item-page/clarin-files-section/clarin-files-section.component.ts`	Adjusted the curl command construction to wrap the output filename and URL in double quotes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Assessment against linked issues

Objective	Addressed	Explanation
Ensure the curl command wraps the output filename in double quotes (#933)	✅

Poem

A curl command hops in with style,
Wrapped in quotes all the while.
No more missing marks,
The bunny leaves no snarks—
Downloads are now proper, and file!
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1c0d6d4 and 9a31681.

📒 Files selected for processing (1)

src/app/item-page/clarin-files-section/clarin-files-section.component.ts (1 hunks)

✅ Files skipped from review due to trivial changes (1)

src/app/item-page/clarin-files-section/clarin-files-section.component.ts

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: dspace-angular / docker-build (linux/amd64, ubuntu-latest, true)
GitHub Check: tests (16.x)
GitHub Check: tests (18.x)

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

src/app/item-page/clarin-files-section/clarin-files-section.component.ts (1)
102-108: fileNames is computed but never used
The fileNames array is built solely to set canShowCurlDownload, then discarded. This is dead code that adds an unnecessary loop every time the command is generated.
-    const fileNames = this.listOfFiles.value.map((file: MetadataBitstream) => {
+    // No need to build an intermediate array; early-exit once we know at least one file is previewable
+    this.canShowCurlDownload = this.listOfFiles.value.some(
+      (file: MetadataBitstream) => file.canPreview
+    );
-      if (file.canPreview) {
-        this.canShowCurlDownload = true;
-      }
-
-      return file.name;
-    });
This eliminates the unused variable and reduces the per-call complexity from O(n) to O(n) with an early exit.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 02e81a6 and ec4869c.

📒 Files selected for processing (1)

src/app/item-page/clarin-files-section/clarin-files-section.component.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)

GitHub Check: dspace-angular / docker-build (linux/amd64, ubuntu-latest, true)
GitHub Check: tests (16.x)
GitHub Check: tests (18.x)

🔇 Additional comments (1)

src/app/item-page/clarin-files-section/clarin-files-section.component.ts (1)

110-110: Quotes correctly added – nice fix 👍
Wrapping both the output filename and the URL in double quotes resolves the copy-&-paste issue in POSIX shells.

src/app/item-page/clarin-files-section/clarin-files-section.component.ts

Copilot

Pull Request Overview

This pull request fixes a formatting issue in the generated curl command by adding proper quoting around the filename and URL. This ensures the command works correctly when copied to command-line environments, especially when URLs or filenames contain special characters or spaces.

Added double quotes around the output filename "allzip.zip"
Added double quotes around the full URL
Refactored the string concatenation to use template literals for improved readability

src/app/item-page/clarin-files-section/clarin-files-section.component.ts

FIX: Add quotes to curl download command

ec4869c

coderabbitai bot reviewed Jul 29, 2025

View reviewed changes

src/app/item-page/clarin-files-section/clarin-files-section.component.ts Outdated Show resolved Hide resolved

vidiecan requested a review from Copilot July 30, 2025 08:56

This comment was marked as outdated.

Sign in to view

Matus-Beke added 3 commits July 30, 2025 11:09

Refactor: Add quotes around URL as well

53076c9

Refactor: Add quotes around URL as well

1c0d6d4

Refactor: Add quotes around URL as well

9a31681

milanmajchrak requested a review from Copilot August 1, 2025 07:28

Copilot AI reviewed Aug 1, 2025

View reviewed changes

src/app/item-page/clarin-files-section/clarin-files-section.component.ts Show resolved Hide resolved

milanmajchrak approved these changes Aug 1, 2025

View reviewed changes

milanmajchrak requested a review from vidiecan August 1, 2025 07:29

vidiecan approved these changes Aug 1, 2025

View reviewed changes

milanmajchrak merged commit 9c58cf5 into dataquest-dev:dtq-dev Aug 1, 2025
6 checks passed

kosarko mentioned this pull request Oct 23, 2025

dataquest -> lindat sync ufal/dspace-angular#62

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

FIX: Add quotes to curl download command #939

FIX: Add quotes to curl download command #939

Uh oh!

Matus-Beke commented Jul 29, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jul 29, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

FIX: Add quotes to curl download command #939

FIX: Add quotes to curl download command #939

Uh oh!

Conversation

Matus-Beke commented Jul 29, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Assessment against linked issues

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Matus-Beke commented Jul 29, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jul 29, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)