Skip to content

Conversation

@jr-rk
Copy link

@jr-rk jr-rk commented Sep 18, 2025

Phases MP MM MB MR JM Total
ETA 0 0 0 0 0 0
Developing 0 0 0 0 0 0
Review 0 0 0 0 0 0
Total - - - - - 0
ETA est. 0
ETA cust. - - - - - 0

Problem description

Displaying the Total Downloads feature in item view, by calling API request for .cfg key item.view.total.downloads.enabled and checking if true.

@jr-rk jr-rk self-assigned this Sep 18, 2025
@jr-rk jr-rk linked an issue Sep 18, 2025 that may be closed by this pull request
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes the Total Downloads feature configurable in the item view by checking a configuration property before displaying the downloads count. The feature is now controlled by the item.view.total.downloads.enabled configuration setting.

  • Adds configuration service integration to check if total downloads should be displayed
  • Introduces conditional rendering based on configuration value
  • Restructures the component to first check configuration before fetching download statistics

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
total-downloads.component.ts Adds configuration service dependency and logic to check item.view.total.downloads.enabled before fetching download statistics
total-downloads.component.html Adds conditional rendering using *ngIf to show downloads only when enabled via configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@jr-rk jr-rk requested a review from Copilot September 18, 2025 14:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@milanmajchrak milanmajchrak merged commit f60bfc8 into customer/vsb-tuo Sep 18, 2025
3 of 5 checks passed
jr-rk added a commit that referenced this pull request Sep 18, 2025
* Implemented configurable showing of component
milanmajchrak pushed a commit that referenced this pull request Nov 7, 2025
* VSB-TUO/Display total downloads for each item (#961)

* Added new feature for downloads of item's bitstreams

* Fixed Copilot's suggestions: any type & redundant property access pattern

* VSB-TUO/Make item view - Total Downloads - configurable (#996)

* Implemented configurable showing of component

* refactor: provide UsageReportDataService as singleton to avoid duplicate instances
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VSB-TUO/Make "Total Downloads" display configurable

3 participants