Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the ability to pass a string to be scanned for filth types… #38

Conversation

seattleopendata
Copy link

…instead of inserting placeholder text. Passing in a string will return an array of the matches.

…tead of inserting placeholder text. Passing in a string will return an array of the matches.
@coveralls
Copy link

coveralls commented Mar 19, 2018

Coverage Status

Coverage decreased (-0.06%) to 96.915% when pulling 2fe0928 on seattleopendata:add-scanning-feature into 914bda4 on datascopeanalytics:master.

@thomasbird
Copy link
Member

Hello and thanks for the contribution!

First off I want to apologise that no one replied to this MR sooner.

Secondly, I'm going to suggest that we close this MR for a few reasons: I think this feature proposal is quite specific to your situation, is already easily accessible via existing APIs and scrubadub v2 has been released (with many new features) so merging this would be hard.

The currently supported way to do this would be to use the scrubber.iter_filth() function and create a set of the types of found filth: {filth.type for filth in scrubber.iter_filth(text)} this would be equivalent to your call to scrubber.scan().

Thanks again,
Thomas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants