Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving mnist example to roughpy (from esig) #7

Merged
merged 16 commits into from
Feb 27, 2024
Merged

Moving mnist example to roughpy (from esig) #7

merged 16 commits into from
Feb 27, 2024

Conversation

rchan26
Copy link
Collaborator

@rchan26 rchan26 commented Feb 14, 2024

Working towards #8 by doing #9.

Updating MNIST example notebook to use RoughPy (0.1.1) for signature computation over esig. Also updating other packages and Python version to 3.11.

Things left to do:

  • replace esig signature computation to roughpy
  • docstrings for MNIST helper functions
  • typehints for MNIST helper functions
  • add pre-commit or some consistent formatting
  • update text that talks about esig to roughpy
    • in README
    • in notebook
  • general tidy-up of notebook

@rchan26 rchan26 marked this pull request as draft February 14, 2024 16:18
@rchan26 rchan26 changed the title Moving mnist example to roughpy over esig Moving mnist example to roughpy (from esig) Feb 25, 2024
@rchan26 rchan26 marked this pull request as ready for review February 25, 2024 22:13
@rchan26 rchan26 merged commit 6c4134c into master Feb 27, 2024
@rchan26 rchan26 deleted the mnist-update branch February 27, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants