We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contrary to the collection classes, the AstraDB and AsyncAstraDB classes have this in their request method:
request
responsebody = cast(API_RESPONSE, response.json())
i.e. unprotected json coercion regardless e.g. of HTTP 500 errors and the like. Thus, the user would see the error as an unparseable JSON.
Proposed solution: the request methods should use the same request handler as done in the collection classes.
(thanks @nicoloboschi for bringing this up!)
The text was updated successfully, but these errors were encountered:
Fix #181 - use request handler for db ops
891e02d
Fix #181 - use request handler for db ops (#185)
6819e67
erichare
Successfully merging a pull request may close this issue.
Contrary to the collection classes, the AstraDB and AsyncAstraDB classes have this in their
request
method:i.e. unprotected json coercion regardless e.g. of HTTP 500 errors and the like. Thus, the user would see the error as an unparseable JSON.
Proposed solution:
the
request
methods should use the same request handler as done in the collection classes.(thanks @nicoloboschi for bringing this up!)
The text was updated successfully, but these errors were encountered: