Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

License check for 0.5.1 Gravitino release #3574

Closed
Tracked by #3563
justinmclean opened this issue May 27, 2024 · 8 comments · Fixed by #3594
Closed
Tracked by #3563

License check for 0.5.1 Gravitino release #3574

justinmclean opened this issue May 27, 2024 · 8 comments · Fixed by #3594
Assignees
@justinmclean
Labels
0.5.1 Release v0.5.1 0.6.0 Release v0.6.0

Comments

@justinmclean
Copy link
Member

justinmclean commented May 27, 2024 •
edited
Loading

Check if LICENSE and NOTICE files need to be updated due to added 3rd party software or changed dependancies. Need to check java dependencies, python client and Web UI.
@justinmclean justinmclean mentioned this issue May 27, 2024
Closed
11 tasks
@justinmclean justinmclean changed the title License check @justinmclean [Epic] License check for 0.5.1 Gravitino release May 27, 2024
@justinmclean justinmclean changed the title [Epic] License check for 0.5.1 Gravitino release License check for 0.5.1 Gravitino release May 27, 2024
@justinmclean justinmclean self-assigned this May 27, 2024
@justinmclean
Copy link
Member Author

LICENSE paths need updating See #3576

@justinmclean
Copy link
Member Author

justinmclean commented May 27, 2024 •
edited
Loading

We're missing origin/license for two SVG files See #3579

@justinmclean
Copy link
Member Author

Checked source and binary LICENSE and NOTICE files and there's no need for any changes, other than #3576 and #3579 above, so everything is fine from a Java point of view. Still need to check WebUI and Python client.

@justinmclean
Copy link
Member Author

justinmclean commented May 27, 2024 •
edited
Loading

For Python the dependancies are:
requests (MIT)
dataclasses-json (MIT)
charset-normalizer (MIT)
idna (BSD 3-clause)
urllib3 (MIT)
certifi (Mozilla Public License)
marshmallow (MIT)
typing-inspect (MIT)
packaging (Apache or MIT)
mypy-extensions (MIT)
typing-extensions (Python license)

None of this code code is included in the release so no changes need to be made to LICENSE or NOTICE.

@justinmclean
Copy link
Member Author

Looking at the WebUI about 80 licenses have changed.

@justinmclean
Copy link
Member Author

There's one very minor issue with @swc/counter as it doesn't have a license. However, it also contains no code and is used to count usage of the swc package so we don't need to include it in the LICENSE file.

@justinmclean
Copy link
Member Author

There's an issue with font license in Web UI - see #3593

@justinmclean justinmclean mentioned this issue May 28, 2024
Merged
@justinmclean
Copy link
Member Author

Review complete. Action is needed on #3593 and #3579.

jerryshao pushed a commit that referenced this issue May 28, 2024
@justinmclean
[#3574] Update licenses to be exact copies and add missing licenses. (#…
28d67dd 
…3594)

### What changes were proposed in this pull request?

Added missing licenses to LICENSE.bin and removed licenses no longer
needed.

### Why are the changes needed?

To comply with ASF license policy.

Fix: #3574

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

N/A
github-actions bot pushed a commit that referenced this issue May 28, 2024
@justinmclean @web-flow
[#3574] Update licenses to be exact copies and add missing licenses. (#…
8cbf459 
…3594)

### What changes were proposed in this pull request?

Added missing licenses to LICENSE.bin and removed licenses no longer
needed.

### Why are the changes needed?

To comply with ASF license policy.

Fix: #3574

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

N/A
@jerryshao jerryshao mentioned this issue May 28, 2024
Merged
@jerryshao jerryshao added 0.5.1 Release v0.5.1 0.6.0 Release v0.6.0 labels May 28, 2024
jerryshao added a commit that referenced this issue May 28, 2024
@jerryshao @justinmclean @yuqi1129
[#3574] Update licenses to be exact copies and add missing licenses. (#…
809122e 
…3597)

### What changes were proposed in this pull request?

Added missing licenses to LICENSE.bin and removed licenses no longer
needed.

### Why are the changes needed?

To comply with ASF license policy.

Fix: #3574

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

N/A

Co-authored-by: Justin Mclean <justin@classsoftware.com>
Co-authored-by: Qi Yu <yuqi@datastrato.com>
diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jun 13, 2024
@justinmclean @diqiu50
[apache#3574] Update licenses to be exact copies and add missing lice…
a3a5bb8 
…nses. (apache#3594)

### What changes were proposed in this pull request?

Added missing licenses to LICENSE.bin and removed licenses no longer
needed.

### Why are the changes needed?

To comply with ASF license policy.

Fix: apache#3574

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@justinmclean justinmclean

Labels
0.5.1 Release v0.5.1 0.6.0 Release v0.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#3574] Update licenses to be exact copies and add missing licenses. justinmclean/gravitino
2 participants
@justinmclean @jerryshao