Fix node removal algorithm for the AVL tree #52
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code responsible for removing nodes from the AVL tree can leave the tree in an invalid state. Whether a node is a left or a right child of its parent is not correctly detected. This is due to a typo. Compare:
with
The first line is not a correct comparison, since the expression
current.getParent().getValue() < 0is a boolean which should not be compared withvalwhich may be a string or a number. The intention is to check which value (eithervalorcurrent.getParent().getValue()) is larger, sothis._compareshould be applied to those directly and then compared with 0. This PR fixes this issue.Additionally the
.removemethod ofAvlTreesometimes doesn't do enough rebalancing. I added a test which shows when that happens and I also added a fix. The problem was with the "case 4" of theremoveRecursivelyfunction not callingthis._balanceNode