Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Row Height?? #15

Closed
blueshirts opened this issue Apr 14, 2014 · 4 comments
Closed

Row Height?? #15

blueshirts opened this issue Apr 14, 2014 · 4 comments

Comments

@blueshirts
Copy link

Is the rowHeight parameter still supported? It is not referenced in the readme docs though it is in the code docs.

* "oScroller": {
*     "rowHeight": 30
* }

Using the follow options did seem to work though is it an incorrect usage?

options.oScroller =
    heights:
        row: 150
@DataTables
Copy link
Collaborator

Yes, still supported, and still in the documentation: http://www.datatables.net/docs/Scroller/1.2.0/Scroller.defaults.html#rowHeight . There is an example of how to use it in the documentation there.

If it isn't working, can you link to an example for me please?

@blueshirts
Copy link
Author

I can try and wire up an example though I was about to get things working with the latest code using the following settings.

oScroller = {
    heights: {
        row: 150
    }
}

I could be wrong but it seems like the related code changes between 1.1 and 1.2. See the highlighted lines below.

https://github.com/DataTables/Scroller/blob/RELEASE_1_1_0/media/js/dataTables.scroller.js#L382-L387

https://github.com/DataTables/Scroller/blob/1.2.0/js/dataTables.scroller.js#L458-L463

@DataTables
Copy link
Collaborator

Yup - good call. I made a mistake trying to make the settings object and configuration object. Shouldn't have done it that way. I've put a workaround in for the moment, and a note to remind myself to improve that code.

The height: { row: ... } method did work before, but not intentionally and this workaround restores the documented way of doing it, but the method you used will no longer work...

Thanks for flagging this up!

@blueshirts
Copy link
Author

Thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant