adds the forestrie confirm message #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
robinbryce
commented
Feb 27, 2024
robinbryce
commented
- Adds MerkleLogConfirm &Adds MerkleLogConfirmMessage
- Adds MerkleLogUnequivocal & MerkleLogUnequivocalMessage (currently empty, just claims the pb ordinals we know we will need)
- Removes MerkleLogCommitMongoDB
- Removes log version, log epoch and massif index. All of which are harmful to our strategy for managing the backing storage. See changing the massifheight for important context
- Adds EventResponseJSONAPI, which largely duplicates EventResponse but importantly, supports decoding the format the customer will see from our apis. The duplication is unfortunate, but it means we can stop having ad-hoc soultions to this problem in all our go-lang based demo code. It also means the data can be reliably decoded with protojson. the generic json unmarshal fails to deal with 64 bit unsigned integers (and other numbers) correctly for example.
honourfish
previously approved these changes
Feb 27, 2024
honourfish
reviewed
Feb 27, 2024
robinbryce
force-pushed
the
dev/robin/8336-signed-merkle-roots-8-returnpath
branch
from
f2638ba to
554a17d
Compare
* Adds MerkleLogConfirm &Adds MerkleLogConfirmMessage * Adds MerkleLogUnequivocal & MerkleLogUnequivocalMessage (currently empty, just claims the pb ordinals we know we will need) * Removes MerkleLogCommitMongoDB * Removes log version, log epoch and massif index. All of which are harmful to our strategy for managing the backing storage. See https://github.com/datatrails/ epic-8120-scalable-proof-mechanisms/ blob/e38ca5e050356a47028b1d2b47bb6f02ff6c5c3c/mmr/ forestrie-mmrblobs.md#changing-the-massifheight-for-a-log for important context * Adds EventResponseJSONAPI, which largely duplicates EventResponse but importantly, supports decoding the format the *customer* will see from our apis. The duplication is unfortunate, but it means we can stop having ad-hoc soultions to this problem in all our go-lang based demo code. It also means the data can be reliably decoded with protojson. the generic json unmarshal fails to deal with 64 bit unsigned integers (and other numbers) correctly for example. Put EventResponseJSONAPI in its own file And add appropriate file comments for both eventresponse.proto and eventresponsejsonapi.proto AB#8336
robinbryce
force-pushed
the
dev/robin/8336-signed-merkle-roots-8-returnpath
branch
from
554a17d to
c3209cd
Compare
honourfish
approved these changes
Feb 28, 2024
robinbryce
deleted the
dev/robin/8336-signed-merkle-roots-8-returnpath
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.