New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't honor .gitignore when searching for services #106

Closed
tristanpemble opened this Issue Nov 29, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@tristanpemble
Contributor

tristanpemble commented Nov 29, 2017

example directory tree:

.
├── .gitignore
├── README.md
├── forge.yaml
├── k8s
│   └── .gitkeep
├── service.yaml
└── workspace
    ├── .gitignore
    └── customer-portal
        ├── Dockerfile
        ├── k8s
        │   └── deployment.yaml
        └── service.yaml

contents of .gitignores:

λ cat .gitignore
forge.yaml
.forge

λ cat workspace/.gitignore
*
!.gitignore

forge pull:

λ forge pull
║ [.forge/payment-processor] git pull
║ Already up-to-date.
║ [.forge/customer-portal] git pull
║ Already up-to-date.
║ git pull
║ Already up-to-date.
║ [.forge/message-broker] git pull
║ Already up-to-date.
║ [.forge/admin-portal] git pull
║ Already up-to-date.
║ 43 tasks run, 0 errors

notice that it is pulling in .forge/customer-portal instead of workspace/customer-portal

@tristanpemble

This comment has been minimized.

Contributor

tristanpemble commented Nov 29, 2017

I created https://github.com/forge-playground/development-environment to sort of illustrate how I am trying to use forge, maybe it will help

@rhs

This comment has been minimized.

Contributor

rhs commented Nov 29, 2017

What about having an explicit search path in forge.yaml for services? I'm just thinking if we ignore .gitignore when searching for services, then we have no way to avoid searching some potentially large directories, e.g. node_modules.

@tristanpemble

This comment has been minimized.

Contributor

tristanpemble commented Nov 30, 2017

works for me 👍

rhs added a commit that referenced this issue Dec 1, 2017

@rhs

This comment has been minimized.

Contributor

rhs commented Dec 1, 2017

This should be fixed in 0.3.21. I added a search-path attribute to forge.yaml that allows you to opt into a search path.

@rhs rhs closed this Dec 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment